From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,T_DKIM_INVALID, T_RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id B52691F404 for ; Fri, 9 Feb 2018 22:09:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753013AbeBIWJe (ORCPT ); Fri, 9 Feb 2018 17:09:34 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36335 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbeBIWJd (ORCPT ); Fri, 9 Feb 2018 17:09:33 -0500 Received: by mail-wr0-f196.google.com with SMTP id y3so9654535wrh.3 for ; Fri, 09 Feb 2018 14:09:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2OhxeZFHz62VSekcWTmGkk6TVmVe9inktqEQy73csPo=; b=GnsYii4dqiyByrjKf0ruIKMT+0t4vMUOCHFVC8a+9MLFM/PQaB4lCPR4PYW7lsg2Rz tqo4ue4fiqCbCsN1mmEo5D0FURtHB966gBYxTidW6c+Pc9PCiUWYhgJnqL+RvLi2A86Q qClrXTwTDeBDxpmrh0HAMkPViui+k1tyI5Wp+fKIDVIFZFUXUf9CyTYligau9dzPLkKq 5FGfN2qyPfvU+Udz3QLN7z3v8URgnXSaUE482wvRPjtlAKUJ0v6Y5AD4tBEEkHj3Bwau YoWbPzqz8KGY1SNfhNwPbO7dlca49lwgVX3k5Wev2OMZniG46ONCqJfCYmilBx/P9Z9F mvag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=2OhxeZFHz62VSekcWTmGkk6TVmVe9inktqEQy73csPo=; b=a54fzQFRhy0neSdmfdv3uUKbtcAMD2HNe1SA16H4krC/Wu50dXs0s0BNAiIxeiO//t YWyGcMGwshYQht0qi7JBjoZbzMqIsZaqc7AHx+EXhoA1oUmaPvh3T1Ilb9V0hbBSdZeU rti+AHzNSyK7LwinWjEqoQfkjFaOYjE8w+B0VC++vNWB/tnnn+76BtVuYGnfoJ3V+b4A n8TEZEg6bdoBZLZ6o8s52Ijq4aGNDxI8ZL9nwABO8l4rb7Oliz8Qb8oosdLi9uBZePXN /lrP2YpwFsY17VWt6AywkGZ+YVSGIzQekmG/N8N4/7oANNjA/zR15iY3oill85T1cDr2 Z8ww== X-Gm-Message-State: APf1xPDeE05h8EpxgrhVy+PICsi2JK6GwwqAnQFIRUw4bqpD0nqYZS0w 1lNpRVTSiXhsWoh9D9VmILg= X-Google-Smtp-Source: AH8x226krlS4Z3xXB5PMhZ5c6l0V23Xc/CW2Dkni0Yq08lFvdQXsAfJ/gimWgCZVWTaywx6Uj2Ou5g== X-Received: by 10.223.136.6 with SMTP id d6mr3630646wrd.191.1518214172136; Fri, 09 Feb 2018 14:09:32 -0800 (PST) Received: from localhost (168.50.187.35.bc.googleusercontent.com. [35.187.50.168]) by smtp.gmail.com with ESMTPSA id 77sm20179wmt.37.2018.02.09.14.09.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Feb 2018 14:09:31 -0800 (PST) From: Junio C Hamano To: Stefan Beller Cc: git@vger.kernel.org, Jonathan Nieder , =?utf-8?Q?Ren=C3=A9?= Scharfe Subject: Re: [PATCH 003/194] object-store: move packed_git and packed_git_mru to object store References: <20180205235508.216277-1-sbeller@google.com> <20180205235508.216277-4-sbeller@google.com> Date: Fri, 09 Feb 2018 14:09:30 -0800 In-Reply-To: <20180205235508.216277-4-sbeller@google.com> (Stefan Beller's message of "Mon, 5 Feb 2018 15:51:57 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Stefan Beller writes: > Patch generated by > > 2. Applying the semantic patch contrib/coccinelle/packed_git.cocci > to adjust callers. About this part... > diff --git a/contrib/coccinelle/packed_git.cocci b/contrib/coccinelle/packed_git.cocci > new file mode 100644 > index 0000000000..da317a51a9 > --- /dev/null > +++ b/contrib/coccinelle/packed_git.cocci > @@ -0,0 +1,7 @@ > +@@ @@ > +- packed_git > ++ the_repository->objects.packed_git > + > +@@ @@ > +- packed_git_mru > ++ the_repository->objects.packed_git_mru The above is correct for one-time transition turning pre-transition code to post the_repository world, but I am not sure if we want to have it in contrib/coccinelle/, where "make coccicheck" looks at, as a way to continuously keep an eye on "style" violations like using strbuf_addf() for a constant when strbuf_addstr() suffices. Wouldn't we need a mechanism to ensure that this file will *not* be used in "make coccicheck" somehow?