From: Junio C Hamano <gitster@pobox.com>
To: tboegi@web.de
Cc: git@vger.kernel.org
Subject: Re: [PATCH v1 1/1] Introduce git add --renormalize .
Date: Tue, 17 Oct 2017 02:34:56 +0900 [thread overview]
Message-ID: <xmqqshejq9mn.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171016164907.4201-1-tboegi@web.de> (tboegi@web.de's message of "Mon, 16 Oct 2017 18:49:07 +0200")
tboegi@web.de writes:
> From: Torsten Bögershausen <tboegi@web.de>
>
> Make it safer to normalize the line endings in a repository:
> Files that had been commited with CRLF will be commited with LF.
> (Unless core.autorclf and .gitattributes specify that Git
> should not do line ending conversions)
A few issues I saw after a quick read:
- The log message tells us old and new ways, but does not make it
clear why users are encouraged to use the new way at all. You
didn't make the implementation of "add --renormalize" to just
start "git add" without calling read_cache() and letting all
files added new to the index (which is how the old way worked) to
give a sugarcoated equivalent of the old way for a reason, and
that should be desribed in the log.
- An ugly global variable is introduced instead of passing
necessary information through the callchain properly, but the
title does not say PATCH/RFC.
- The documentation makes it sound as if this new feature is _only_
about CRLF vs LF. SHouldn't this equally apply after the user
changes .gitattributes settings that govern the "clean" side of
the filter and makes what is in the index "unclean"?
The second point is a showstopper from maintainability's point of
view, but none of the above should be insurmojntable.
Thanks.
next prev parent reply other threads:[~2017-10-16 17:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 15:00 Line ending normalization doesn't work as expected Robert Dailey
2017-10-03 16:26 ` Torsten Bögershausen
2017-10-03 17:23 ` Robert Dailey
2017-10-03 19:19 ` Torsten Bögershausen
2017-10-04 2:00 ` Junio C Hamano
2017-10-04 16:26 ` Robert Dailey
2017-10-04 16:59 ` Jonathan Nieder
2017-10-04 18:03 ` Robert Dailey
2017-10-05 1:31 ` Junio C Hamano
2017-10-05 1:46 ` Jonathan Nieder
2017-10-04 21:17 ` Torsten Bögershausen
2017-10-05 1:38 ` Junio C Hamano
2017-10-05 3:31 ` Junio C Hamano
2017-10-05 21:42 ` Torsten Bögershausen
2017-10-06 0:33 ` Junio C Hamano
2017-10-06 17:58 ` Torsten Bögershausen
2017-10-16 16:49 ` [PATCH v1 1/1] Introduce git add --renormalize tboegi
2017-10-16 17:34 ` Junio C Hamano [this message]
2017-10-30 16:29 ` [PATCH v2 " tboegi
2017-11-07 5:50 ` Junio C Hamano
2017-11-07 17:26 ` Torsten Bögershausen
2017-11-08 0:37 ` Junio C Hamano
2017-11-09 18:47 ` Torsten Bögershausen
2017-11-10 0:22 ` Junio C Hamano
2017-11-12 20:08 ` Torsten Bögershausen
2017-11-16 16:38 ` [PATCH v3 " tboegi
2017-11-17 1:24 ` Junio C Hamano
2017-11-17 20:44 ` Eric Sunshine
2017-11-18 1:47 ` Junio C Hamano
2018-02-15 15:24 ` Line ending normalization doesn't work as expected Robert Dailey
2018-02-15 19:16 ` Junio C Hamano
2018-02-15 21:47 ` Robert Dailey
2018-02-16 16:34 ` Torsten Bögershausen
2018-02-16 17:19 ` Robert Dailey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqshejq9mn.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.