From: Junio C Hamano <gitster@pobox.com>
To: Chris Packham <judge.packham@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv1] completion: add option '--recurse-submodules' to 'git clone'
Date: Wed, 27 Jul 2016 10:21:36 -0700 [thread overview]
Message-ID: <xmqqshuvvvxb.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160727083406.10241-1-judge.packham@gmail.com> (Chris Packham's message of "Wed, 27 Jul 2016 20:34:06 +1200")
Chris Packham <judge.packham@gmail.com> writes:
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> Hi,
>
> I noticed --recurse-submodules was missing from the bash completion. This adds
> it. I went for '--recurse-submodules' instead of '--recursive' as I seem to
> recall the former being agreed upon as the better (or least ambiguous) of the
> two terms.
Yup, that position is consistent with what 3446a54c (clone: fixup
recurse_submodules option, 2011-02-11) gave us.
Perhaps we should think about deprecating "--recursive"? I dunno.
> contrib/completion/git-completion.bash | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 37888f4..7c06455 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1136,6 +1136,7 @@ _git_clone ()
> --depth
> --single-branch
> --branch
> + --recurse-submodules
> "
> return
> ;;
next prev parent reply other threads:[~2016-07-27 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 8:34 [PATCHv1] completion: add option '--recurse-submodules' to 'git clone' Chris Packham
2016-07-27 17:21 ` Junio C Hamano [this message]
2016-07-27 17:32 ` Junio C Hamano
2016-07-27 17:41 ` Stefan Beller
2016-07-28 16:22 ` Junio C Hamano
2016-07-29 1:26 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqshuvvvxb.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=judge.packham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.