From: Junio C Hamano <gitster@pobox.com>
To: Ronald Weiss <weiss.ronald@gmail.com>
Cc: Jens Lehmann <Jens.Lehmann@web.de>,
git@vger.kernel.org, Heiko Voigt <hvoigt@hvoigt.net>
Subject: Re: [PATCH v3 2/2] commit: add --ignore-submodules[=<when>] parameter
Date: Mon, 14 Apr 2014 14:08:43 -0700 [thread overview]
Message-ID: <xmqqsipfmxes.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <534C429A.6080508@gmail.com> (Ronald Weiss's message of "Mon, 14 Apr 2014 22:18:34 +0200")
Ronald Weiss <weiss.ronald@gmail.com> writes:
> On 14. 4. 2014 20:30, Junio C Hamano wrote:
>> Ronald Weiss <weiss.ronald@gmail.com> writes:
>>
>>> On 8. 4. 2014 20:43, Jens Lehmann wrote:
>>>>> Useful <when> values for commit are 'all' (default) or 'none'. The others
>>>>> ('dirty' and 'untracked') have same effect as 'none', as commit is only
>>>>> interested in whether the submodule's HEAD differs from what is commited
>>>>> in the superproject.
>>>>
>>>> Unless it outputs a status message, then 'dirty' and 'untracked' do
>>>> influence what is shown there. Apart from that (and maybe tests for
>>>> these two cases ;-) this is looking good to me.
>>>
>>> OK, I updated the patch for commit to take that into account. Also, I
>>> rebased both patches onto current master. Sending them in a moment.
>>>
>>> If you don't have any more complaints, can I add "Acked-by: <you>" and
>>> resend the patches to Junio?
>>
>> It is not "When I see no more complaints, I'll resend with your
>> Ack". An Ack is a positive thing, not lack of discovery of further
>> issues.
>
> I'm really sorry if the tone of my message sounded harsh to you, it
> wasn't meant like that at all.
No, that wasn't harsh at all. I just did not want to get a patch
with Acked-by with somebody's name on it, when there is not yet an
Ack, as that will confuse me greatly. My mental bandwidth is not
wide enough to keep track of all the in-flight topics I haven't yet
picked up.
I should be the one to say sorry if my message sounded harsh.
Thanks.
>> Rather, it is more like "I'll wait for your Acks and then I'll
>> resend with your Ack", or "If they look good, reply with Ack and let
>> the maintainer pick them up".
>
> OK.
next prev parent reply other threads:[~2014-04-14 21:19 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 23:36 git commit vs. ignore-submodules Ronald Weiss
2014-03-28 16:47 ` Jens Lehmann
2014-03-28 17:59 ` Junio C Hamano
2014-03-29 22:44 ` Ronald Weiss
2014-03-29 22:50 ` [PATCH 1/2] commit: add --ignore-submodules[=<when>] parameter Ronald Weiss
2014-03-29 23:14 ` Jens Lehmann
2014-03-30 19:48 ` Jens Lehmann
2014-03-30 23:43 ` [PATCH v2] " Ronald Weiss
2014-03-31 0:07 ` [PATCH v2.1] " Ronald Weiss
2014-03-31 18:58 ` Jens Lehmann
2014-03-31 20:37 ` Jens Lehmann
2014-03-31 21:50 ` Ronald Weiss
2014-03-31 21:47 ` Ronald Weiss
2014-03-31 22:50 ` Ronald Weiss
2014-03-31 23:35 ` Ronald Weiss
2014-04-01 20:23 ` Jens Lehmann
2014-04-01 21:59 ` Ronald Weiss
2014-04-02 18:53 ` Jens Lehmann
2014-04-02 19:56 ` Ronald Weiss
2014-04-06 16:28 ` Jens Lehmann
2014-04-07 21:46 ` Ronald Weiss
2014-04-07 23:01 ` [PATCH v3 1/2] add: " Ronald Weiss
2014-04-07 23:03 ` [PATCH v3 2/2] commit: " Ronald Weiss
2014-04-08 18:43 ` Jens Lehmann
2014-04-08 20:19 ` Ronald Weiss
2014-04-12 22:20 ` Ronald Weiss
2014-04-12 22:45 ` [PATCH v4 1/2] add: " Ronald Weiss
2014-04-18 11:53 ` Jens Lehmann
2014-04-21 21:19 ` Ronald Weiss
2014-04-12 22:49 ` [PATCH v4 2/2] commit: " Ronald Weiss
2014-04-18 12:09 ` Jens Lehmann
2014-04-21 22:08 ` Ronald Weiss
2014-04-22 19:14 ` Jens Lehmann
2014-04-22 21:12 ` [PATCH v5 1/2] add: " Ronald Weiss
2014-04-23 20:25 ` Eric Sunshine
2014-04-24 19:34 ` [PATCH v6 " Ronald Weiss
2014-04-24 19:42 ` [PATCH v6 2/2] commit: " Ronald Weiss
2014-04-22 21:13 ` [PATCH v5 " Ronald Weiss
2014-04-14 18:30 ` [PATCH v3 " Junio C Hamano
2014-04-14 20:18 ` Ronald Weiss
2014-04-14 21:08 ` Junio C Hamano [this message]
2014-04-08 18:26 ` [PATCH v2.1] " Jens Lehmann
2014-04-12 23:41 ` Ronald Weiss
2014-04-18 12:28 ` Jens Lehmann
2014-04-22 22:21 ` Ronald Weiss
2014-03-31 17:14 ` [PATCH 1/2] " Junio C Hamano
2014-03-29 22:56 ` [PATCH 2/2] status: don't ignore submodules added to index Ronald Weiss
2014-03-29 23:16 ` Jens Lehmann
2014-03-29 23:40 ` Ronald Weiss
2014-03-30 0:01 ` Ronald Weiss
2014-03-30 10:14 ` [WIP/PATCH] status/commit: always show staged submodules regardless of ignore config Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsipfmxes.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=weiss.ronald@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.