All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
	"Marco Trevisan via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "Marco Trevisan" <mail@3v1n0.net>
Subject: Re: [PATCH] completion: use native ZSH array pattern matching
Date: Thu, 28 May 2020 16:01:05 -0700	[thread overview]
Message-ID: <xmqqtuzz1x72.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200528225733.GI1915090@camp.crustytoothpaste.net> (brian m. carlson's message of "Thu, 28 May 2020 22:57:33 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> On 2020-05-28 at 15:54:49, Junio C Hamano wrote:
>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> > Yes, that is what I meant.  I'm glad to know my question has been
>> > answered and things work.  I'm okay with the patch as it is in that
>> > case, although I'd give bonus points for mentioning that this syntax
>> > doesn't regress bash.
>> 
>> True.  And we would want to also have tested-by on more recent
>> versions of bash, no?
>
> Sure, such testing would be welcome, but I believe those are tested with
> our tests on most platforms.  macOS is special because it uses the last
> GPLv2 version of bash, which is less capable in some ways.  I assumed
> that bash would not be more likely to break here in newer versions, but
> perhaps I shouldn't make that assumption.

In any case, a few integration into 'pu' with the patch have been
already made e.g. https://travis-ci.org/github/git/git/builds/692290894
so we should be good ;-)


  reply	other threads:[~2020-05-28 23:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 19:13 [PATCH] completion: use native ZSH array pattern matching Marco Trevisan via GitGitGadget
2020-05-26 23:58 ` brian m. carlson
2020-05-27  6:13   ` Carlo Marcelo Arenas Belón
2020-05-28  2:17     ` brian m. carlson
2020-05-28 15:54       ` Junio C Hamano
2020-05-28 22:57         ` brian m. carlson
2020-05-28 23:01           ` Junio C Hamano [this message]
2020-05-28 16:14 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtuzz1x72.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=mail@3v1n0.net \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.