All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, josef@kufner.cz
Subject: Re: [PATCH 0/2] Log pretty format alignment improvements
Date: Thu, 16 Jun 2016 11:25:28 -0700	[thread overview]
Message-ID: <xmqqtwgt3s9z.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160616131838.14440-1-pclouds@gmail.com> (=?utf-8?B?Ik5n?= =?utf-8?B?dXnhu4VuIFRow6FpIE5n4buNYw==?= Duy"'s message of "Thu, 16 Jun 2016 20:18:36 +0700")

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> The first patch was from a long time ago. The concern was it may be
> breaking existing user expectation [1]. I still maintain that it's a good
> thing to do and should not break anything. Hence the resubmission.

I do not think "it's a good feature to have" was a question from the
beginning.  Thread [1] stopped with me saying "as long as >(N) can
be used as Duy claims as a workaround to get the original behaviour,
it is good to allow using >|(N) for this new output format; I didn't
check if >(N) does behave that way, though".  What was necessary to
resurrect the patch was "Yes, >(N) can be used that way and here is
a test" or something like that.

> The second patch adds negative column specifier to >|() and friends.
> A positive number 'n' specifies the n-th column from the left border
> of the screen, '-n' specifies the n-th column from the _right_ border.

That is quite nice enhancement.

  parent reply	other threads:[~2016-06-16 18:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 13:18 [PATCH 0/2] Log pretty format alignment improvements Nguyễn Thái Ngọc Duy
2016-06-16 13:18 ` [PATCH 1/2] pretty: pass graph width to pretty formatting for use in '%>|(N)' Nguyễn Thái Ngọc Duy
2016-06-16 13:18 ` [PATCH 2/2] pretty.c: support <direction>|(<negative number>) forms Nguyễn Thái Ngọc Duy
2016-06-16 18:25 ` Junio C Hamano [this message]
2016-06-17 11:27   ` [PATCH 0/2] Log pretty format alignment improvements Duy Nguyen
2016-06-17 16:43     ` Junio C Hamano
2016-06-17 17:24   ` Josef Kufner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtwgt3s9z.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=josef@kufner.cz \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.