From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Caleb Thompson <caleb@calebthompson.io>,
git@vger.kernel.org, Jeremiah Mahler <jmmahler@gmail.com>,
Duy Nguyen <pclouds@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Johannes Sixt <j.sixt@viscovery.net>, David Kastrup <dak@gnu.org>,
Mike Burns <mike@mike-burns.com>
Subject: Re: [PATCH v5 3/4] commit test: test_set_editor in each test
Date: Fri, 13 Jun 2014 10:42:26 -0700 [thread overview]
Message-ID: <xmqqtx7o3dvh.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140613065942.GB7908@sigill.intra.peff.net> (Jeff King's message of "Fri, 13 Jun 2014 02:59:42 -0400")
Jeff King <peff@peff.net> writes:
> [1] It might make sense for test_set_editor, when run from within a
> test, to behave more like test_config, and do:
>
> test_when_finished '
> sane_unset FAKE_EDITOR &&
> sane_unset EDITOR
> '
>
> I don't know if there would be fallouts with other test scripts,
> though.
The default environment for tests is to set EDITOR=: to avoid
accidentally triggering interactive cruft and interfering with
automated tests, I thought.
If the above sane-unset is changed to EDITOR=: then I think that is
probably sensible.
next prev parent reply other threads:[~2014-06-13 17:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 19:38 [PATCH v5 0/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-12 19:38 ` [PATCH v5 1/4] commit test: Use test_config instead of git-config Caleb Thompson
2014-06-12 19:39 ` [PATCH v5 2/4] commit test: Use write_script Caleb Thompson
2014-06-13 6:50 ` Jeff King
2014-06-13 16:26 ` Caleb Thompson
2014-06-13 23:28 ` Jeff King
2014-06-12 19:39 ` [PATCH v5 3/4] commit test: test_set_editor in each test Caleb Thompson
2014-06-13 6:59 ` Jeff King
2014-06-13 16:36 ` Caleb Thompson
2014-06-13 17:16 ` Jakub Narębski
2014-06-13 17:47 ` Caleb Thompson
2014-06-13 18:52 ` Jakub Narębski
2014-06-13 23:39 ` Jeff King
2014-06-13 17:42 ` Junio C Hamano [this message]
2014-06-13 23:41 ` Jeff King
2014-06-16 17:46 ` Caleb Thompson
2014-06-16 18:58 ` Junio C Hamano
2014-06-12 20:00 ` [PATCH v5 4/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-13 17:48 ` Junio C Hamano
2014-06-16 19:50 ` Caleb Thompson
2014-06-16 20:05 ` Caleb Thompson
2014-06-16 20:06 ` Junio C Hamano
2014-06-16 20:10 ` Caleb Thompson
2014-06-16 22:25 ` Junio C Hamano
2014-06-12 20:30 ` [PATCH v5 0/4] " Jeremiah Mahler
2014-06-13 16:49 ` Caleb Thompson
2014-06-14 4:14 ` Jeremiah Mahler
2014-06-16 20:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtx7o3dvh.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=caleb@calebthompson.io \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=jmmahler@gmail.com \
--cc=mike@mike-burns.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.