All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Elia Pinto <gitter.spiros@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] curl: streamline conditional compilation
Date: Wed, 16 Mar 2022 11:04:18 -0700	[thread overview]
Message-ID: <xmqqy219lqot.fsf@gitster.g> (raw)
In-Reply-To: <220316.86h77ydkfl.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Wed, 16 Mar 2022 15:43:09 +0100")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> The way it was being done before was intentional & discused on list.
>
> See my original
> https://lore.kernel.org/git/patch-v3-7.7-93a2775d0ee-20210730T092843Z-avarab@gmail.com/
> which did it pretty much like that, and Junio's subsequent
> follow-up. I.e. this breadcrumb trail:
> https://lore.kernel.org/git/?q=CURL_SOCKOPT_OK
>
>> -#if LIBCURL_VERSION_NUM < 0x071505
>> -#define CURL_SOCKOPT_OK 0
>> +#if LIBCURL_VERSION_NUM >= 0x071505
>> +#define GIT_CURL_HAVE_CURL_SOCKOPT_OK 1
>>  #endif
>
> IOW we should drop this.

I think that depends on the worldview.

In a world in which [PATCH 2/2] is a good idea, i.e. "we have a
comprehensive catalog of available cURL features, but it expresses
its knowledge in one particular way, i.e. HAVE_X", the above,
together with the change at the only use site in http.c, are very
sensible changes.

Given that we do not want to have too many conditionally compiled
codepath, I certainly understand that the current approach to keep
an ad-hoc list of features we care about may be your preference.

I am not sure if that is viable longer term, though.  I still am not
decided.

Thanks.

  reply	other threads:[~2022-03-16 18:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 14:01 [PATCH 0/2] addition of all symbols defined by curl Elia Pinto
2022-03-16 14:01 ` [PATCH 1/2] curl: streamline conditional compilation Elia Pinto
2022-03-16 14:43   ` Ævar Arnfjörð Bjarmason
2022-03-16 18:04     ` Junio C Hamano [this message]
2022-03-16 14:01 ` [PATCH 2/2] git-curl-compat.h: addition of all symbols defined by curl Elia Pinto
2022-03-16 14:47   ` Ævar Arnfjörð Bjarmason
2022-03-16 22:24     ` Elia Pinto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy219lqot.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitter.spiros@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.