All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Pratyush Yadav <me@yadavpratyush.com>
Cc: "Zoli Szabó via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "Zoli Szabó" <zoli.szabo@gmail.com>
Subject: Re: [PATCH 1/1] git-gui: add possibility to open currently selected file
Date: Fri, 27 Dec 2019 14:32:10 -0800	[thread overview]
Message-ID: <xmqqy2uxiemt.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191227193418.36uzeizs37nv7ywb@yadavpratyush.com> (Pratyush Yadav's message of "Sat, 28 Dec 2019 01:04:18 +0530")

Pratyush Yadav <me@yadavpratyush.com> writes:

> Have you tested it on Windows? Does 'explorer.exe' do the correct thing? 
>
> Looking at MacOS's 'open' man page, I think it should also work like 
> xdg-open and shouldn't be a problem.
> ...
> Tested on Linux. Works fine. Looking forward to the re-roll.

> Subject: Re: [PATCH 1/1] git-gui: add possibility to open currently selected file

The phrasing on the title is a bit awkward.  "add possibility to do
X" is better spelled "allow doing X", no?

  reply	other threads:[~2019-12-27 22:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-26 19:01 [PATCH 0/1] git-gui: add possibility to open currently selected file Zoli Szabó via GitGitGadget
2019-12-26 19:01 ` [PATCH 1/1] " Zoli Szabó via GitGitGadget
2019-12-27 19:34   ` Pratyush Yadav
2019-12-27 22:32     ` Junio C Hamano [this message]
2019-12-29 20:15       ` Zoli Szabó
2019-12-29 23:14         ` Junio C Hamano
2019-12-30 16:13           ` Zoli Szabó
2019-12-29 13:23     ` Zoli Szabó
2019-12-29 19:32 ` [PATCH v2 0/1] git-gui: allow opening " Zoli Szabó via GitGitGadget
2019-12-29 19:32   ` [PATCH v2 1/1] " Zoli Szabó via GitGitGadget
2019-12-30 15:56   ` [PATCH v3 0/1] " Zoli Szabó via GitGitGadget
2019-12-30 15:56     ` [PATCH v3 1/1] git-gui: allow opening currently selected file in default app Zoli Szabó via GitGitGadget
2019-12-30 19:41       ` Pratyush Yadav
2019-12-30 20:31         ` Zoli Szabó

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy2uxiemt.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=me@yadavpratyush.com \
    --cc=zoli.szabo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.