All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Raghul Nanth A <nanth.raghul@gmail.com>
Cc: vdye@github.com, derrickstolee@github.com, git@vger.kernel.org
Subject: Re: [GSOC][PATCH] describe: enable sparse index for describe
Date: Fri, 31 Mar 2023 09:34:40 -0700	[thread overview]
Message-ID: <xmqqzg7sg9r3.fsf@gitster.g> (raw)
In-Reply-To: <20230331154329.121958-1-nanth.raghul@gmail.com> (Raghul Nanth A.'s message of "Fri, 31 Mar 2023 21:13:29 +0530")

Raghul Nanth A <nanth.raghul@gmail.com> writes:

> Add usage and performance tests for describe

I think the commit is better off without this line.

> git describe compares the index with the working tree when (and only
> when) it is run with the "--dirty" flag. This is done by the
> ...
>
> Signed-off-by: Raghul Nanth A <nanth.raghul@gmail.com>
> ---

Here is where you describe what got changed since the previous
iteration (and following [PATCH v<N>] notational convention would
help people to see which one is meant to be the latest).  These two
are especially helpful when you send more or less identical patches
in quick succession like within a few hours.

Thanks.

  reply	other threads:[~2023-03-31 16:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 14:20 [PATCH] describe: enable sparse index for describe Raghul Nanth A via GitGitGadget
2023-03-27 18:26 ` Junio C Hamano
2023-03-28 19:46   ` Derrick Stolee
2023-03-28 20:24     ` Junio C Hamano
2023-03-28 20:35       ` Derrick Stolee
2023-03-29 16:25 ` [PATCH v2] " Raghul Nanth A via GitGitGadget
2023-03-29 17:00   ` Junio C Hamano
2023-03-29 17:49   ` Victoria Dye
2023-03-29 18:27     ` Junio C Hamano
2023-03-30 16:10     ` Raghul Nanth
2023-04-03 16:37       ` Victoria Dye
2023-03-30  5:59   ` [PATCH v3] " Raghul Nanth A via GitGitGadget
2023-03-30 14:57     ` Junio C Hamano
2023-03-30 15:13       ` Junio C Hamano
2023-03-30 16:23     ` Victoria Dye
2023-03-31 15:43       ` [GSOC][PATCH] " Raghul Nanth A
2023-03-31 16:34         ` Junio C Hamano [this message]
2023-03-31 18:20     ` [GSOC][PATCH v4] " Raghul Nanth A
2023-04-03 16:34       ` Victoria Dye
2023-04-03 16:47       ` [GSOC][PATCH v5] " Raghul Nanth A
2023-04-03  7:35     ` [PATCH v4] " Raghul Nanth A
2023-03-31 14:27 [GSOC][PATCH] " Raghul Nanth A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzg7sg9r3.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=nanth.raghul@gmail.com \
    --cc=vdye@github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.