From: Junio C Hamano <gitster@pobox.com>
To: Faiz Kothari <faiz.off93@gmail.com>
Cc: git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH] implemented strbuf_write_or_die()
Date: Mon, 03 Mar 2014 10:27:14 -0800 [thread overview]
Message-ID: <xmqqzjl7qgsd.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1393672871-28281-1-git-send-email-faiz.off93@gmail.com> (Faiz Kothari's message of "Sat, 1 Mar 2014 16:51:11 +0530")
Faiz Kothari <faiz.off93@gmail.com> writes:
> Signed-off-by: Faiz Kothari <faiz.off93@gmail.com>
> ---
> Implemented write_or_die.c:strbuf_write_or_die() and used in relevant places
> to substitute write_or_die(). I spotted other places where strbuf can be used
> in place of buf[MAX_PATH] but that would require a change in prototype of a
> lot of functions and functions calling them and so on....
> I'll look for more places where strbuf can be used safely.
>
> Thanks.
>
> builtin/cat-file.c | 2 +-
> builtin/notes.c | 4 ++--
> builtin/receive-pack.c | 2 +-
> builtin/send-pack.c | 2 +-
> builtin/stripspace.c | 2 +-
> builtin/tag.c | 2 +-
> bundle.c | 2 +-
> cache.h | 1 +
> credential-store.c | 2 +-
> fetch-pack.c | 2 +-
> http-backend.c | 2 +-
> remote-curl.c | 8 +++++---
> write_or_die.c | 9 +++++++++
> 13 files changed, 26 insertions(+), 14 deletions(-)
It does not reduce the code, it does not make the resulting code
read any easier.
What is the benefit of this change?
prev parent reply other threads:[~2014-03-03 18:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-01 11:21 [PATCH] implemented strbuf_write_or_die() Faiz Kothari
2014-03-01 12:51 ` He Sun
2014-03-01 13:29 ` Faiz Kothari
2014-03-01 22:33 ` Michael Haggerty
2014-03-02 0:18 ` [PATCH v2] " Faiz Kothari
2014-03-02 2:47 ` Eric Sunshine
2014-03-02 2:55 ` Eric Sunshine
2014-03-02 7:34 ` [PATCH v3 1/2] Introduce strbuf_write_or_die() Faiz Kothari
2014-03-02 7:34 ` [PATCH v3 2/2] use strbuf_write_or_die() Faiz Kothari
2014-03-02 22:04 ` Eric Sunshine
2014-03-02 20:05 ` [PATCH v3 1/2] Introduce strbuf_write_or_die() Eric Sunshine
2014-03-02 3:08 ` [PATCH] implemented strbuf_write_or_die() Eric Sunshine
2014-03-03 18:31 ` Junio C Hamano
[not found] ` <CAFbjVckhU7NHzLjqPo5WkoBwVLrOLg=CS6mHSKkQstUxB31_eA@mail.gmail.com>
2014-03-03 18:48 ` Fwd: " Faiz Kothari
2014-03-03 19:46 ` Eric Sunshine
2014-03-03 19:51 ` David Kastrup
2014-03-03 20:35 ` Junio C Hamano
2014-03-03 21:29 ` Eric Sunshine
2014-03-04 9:18 ` Michael Haggerty
2014-03-04 17:01 ` Faiz Kothari
2014-03-04 18:45 ` Junio C Hamano
2014-03-01 21:34 ` Johannes Sixt
2014-03-03 18:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzjl7qgsd.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=faiz.off93@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.