From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Thelen Subject: Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies" Date: Mon, 28 May 2018 11:02:40 -0700 Message-ID: References: <20180525213123.2113748-1-arnd@arndb.de> <20180528163949.GA17505@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Return-path: In-Reply-To: <20180528163949.GA17505@ziepe.ca> Sender: linux-kernel-owner@vger.kernel.org To: Jason Gunthorpe Cc: arnd@arndb.de, Doug Ledford , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, gregkh@linuxfoundation.org, Steve French , ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net, "David S. Miller" , santosh.shilimkar@oracle.com, trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, bfields@fieldses.org, jlayton@kernel.org, Bart Van Assche , linux-rdma@vger.kernel.org, LKML , linux-nvme@lists.infradead.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org, samba-techni List-Id: linux-rdma@vger.kernel.org Jason Gunthorpe wrote: > On Fri, May 25, 2018 at 05:32:52PM -0700, Greg Thelen wrote: >> On Fri, May 25, 2018 at 2:32 PM Arnd Bergmann wrote: >> > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn >> depends >> > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a >> > link error when another driver using it is built-in. The >> > INFINIBAND_ADDR_TRANS dependency is insufficient here as this is >> > a 'bool' symbol that does not force anything to be a module in turn. >> > fs/cifs/smbdirect.o: In function `smbd_disconnect_rdma_work': >> > smbdirect.c:(.text+0x1e4): undefined reference to `rdma_disconnect' >> > net/9p/trans_rdma.o: In function `rdma_request': >> > trans_rdma.c:(.text+0x7bc): undefined reference to `rdma_disconnect' >> > net/9p/trans_rdma.o: In function `rdma_destroy_trans': >> > trans_rdma.c:(.text+0x830): undefined reference to `ib_destroy_qp' >> > trans_rdma.c:(.text+0x858): undefined reference to `ib_dealloc_pd' >> > Fixes: 9533b292a7ac ("IB: remove redundant INFINIBAND kconfig >> dependencies") >> > Signed-off-by: Arnd Bergmann >> Acked-by: Greg Thelen >> Sorry for the 9533b292a7ac problem. >> At this point the in release cycle, I think Arnd's revert is best. >> If there is interest, I've put a little thought into an alternative fix: >> making INFINIBAND_ADDR_TRANS tristate. But it's nontrivial. >> So I prefer this simple revert for now. > Is that a normal thing to do? For me: no, it's not normal. In my use case I merely want to disable INFINIBAND_ADDR_TRANS while continuing to use INFINIBAND. This is supported with f7cb7b85be55 ("IB: make INFINIBAND_ADDR_TRANS configurable"). During f7cb7b85be55 development https://lkml.org/lkml/2018/4/30/1073 suggested that we drop dependency on both INFINIBAND and INFINIBAND_ADDR_TRANS. Thus 9533b292a7ac ("IB: remove redundant INFINIBAND kconfig dependencies"). But 9533b292a7ac led to the randconfig build errors reported and thus ("IB: Revert "remove redundant INFINIBAND kconfig dependencies""). So I see no need to do anything more than apply ("IB: Revert "remove redundant INFINIBAND kconfig dependencies""). >> Doug: do you need anything from me on this? > I can take the revert.. > Jason Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932856AbeE1SCx (ORCPT ); Mon, 28 May 2018 14:02:53 -0400 Received: from mail-qk0-f201.google.com ([209.85.220.201]:34919 "EHLO mail-qk0-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932824AbeE1SCo (ORCPT ); Mon, 28 May 2018 14:02:44 -0400 X-Google-Smtp-Source: ADUXVKJfAmcPf43sm6gWUSNrpV6YnSA6liDk538VoLTyINDDJGKv45cnEe2jh4brZ+C15uqXXSlE01splw2E Date: Mon, 28 May 2018 11:02:40 -0700 In-Reply-To: <20180528163949.GA17505@ziepe.ca> Message-Id: Mime-Version: 1.0 References: <20180525213123.2113748-1-arnd@arndb.de> <20180528163949.GA17505@ziepe.ca> Subject: Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies" From: Greg Thelen To: Jason Gunthorpe Cc: arnd@arndb.de, Doug Ledford , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, gregkh@linuxfoundation.org, Steve French , ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net, "David S. Miller" , santosh.shilimkar@oracle.com, trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, bfields@fieldses.org, jlayton@kernel.org, Bart Van Assche , linux-rdma@vger.kernel.org, LKML , linux-nvme@lists.infradead.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org, rds-devel@oss.oracle.com, linux-nfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jason Gunthorpe wrote: > On Fri, May 25, 2018 at 05:32:52PM -0700, Greg Thelen wrote: >> On Fri, May 25, 2018 at 2:32 PM Arnd Bergmann wrote: >> > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn >> depends >> > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a >> > link error when another driver using it is built-in. The >> > INFINIBAND_ADDR_TRANS dependency is insufficient here as this is >> > a 'bool' symbol that does not force anything to be a module in turn. >> > fs/cifs/smbdirect.o: In function `smbd_disconnect_rdma_work': >> > smbdirect.c:(.text+0x1e4): undefined reference to `rdma_disconnect' >> > net/9p/trans_rdma.o: In function `rdma_request': >> > trans_rdma.c:(.text+0x7bc): undefined reference to `rdma_disconnect' >> > net/9p/trans_rdma.o: In function `rdma_destroy_trans': >> > trans_rdma.c:(.text+0x830): undefined reference to `ib_destroy_qp' >> > trans_rdma.c:(.text+0x858): undefined reference to `ib_dealloc_pd' >> > Fixes: 9533b292a7ac ("IB: remove redundant INFINIBAND kconfig >> dependencies") >> > Signed-off-by: Arnd Bergmann >> Acked-by: Greg Thelen >> Sorry for the 9533b292a7ac problem. >> At this point the in release cycle, I think Arnd's revert is best. >> If there is interest, I've put a little thought into an alternative fix: >> making INFINIBAND_ADDR_TRANS tristate. But it's nontrivial. >> So I prefer this simple revert for now. > Is that a normal thing to do? For me: no, it's not normal. In my use case I merely want to disable INFINIBAND_ADDR_TRANS while continuing to use INFINIBAND. This is supported with f7cb7b85be55 ("IB: make INFINIBAND_ADDR_TRANS configurable"). During f7cb7b85be55 development https://lkml.org/lkml/2018/4/30/1073 suggested that we drop dependency on both INFINIBAND and INFINIBAND_ADDR_TRANS. Thus 9533b292a7ac ("IB: remove redundant INFINIBAND kconfig dependencies"). But 9533b292a7ac led to the randconfig build errors reported and thus ("IB: Revert "remove redundant INFINIBAND kconfig dependencies""). So I see no need to do anything more than apply ("IB: Revert "remove redundant INFINIBAND kconfig dependencies""). >> Doug: do you need anything from me on this? > I can take the revert.. > Jason Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Thelen Date: Mon, 28 May 2018 11:02:40 -0700 Subject: [lustre-devel] [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies" In-Reply-To: <20180528163949.GA17505@ziepe.ca> References: <20180525213123.2113748-1-arnd@arndb.de> <20180528163949.GA17505@ziepe.ca> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jason Gunthorpe Cc: arnd@arndb.de, Doug Ledford , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, gregkh@linuxfoundation.org, Steve French , ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net, "David S. Miller" , santosh.shilimkar@oracle.com, trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, bfields@fieldses.org, jlayton@kernel.org, Bart Van Assche , linux-rdma@vger.kernel.org, LKML , linux-nvme@lists.infradead.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org, samba-techni Jason Gunthorpe wrote: > On Fri, May 25, 2018 at 05:32:52PM -0700, Greg Thelen wrote: >> On Fri, May 25, 2018 at 2:32 PM Arnd Bergmann wrote: >> > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn >> depends >> > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a >> > link error when another driver using it is built-in. The >> > INFINIBAND_ADDR_TRANS dependency is insufficient here as this is >> > a 'bool' symbol that does not force anything to be a module in turn. >> > fs/cifs/smbdirect.o: In function `smbd_disconnect_rdma_work': >> > smbdirect.c:(.text+0x1e4): undefined reference to `rdma_disconnect' >> > net/9p/trans_rdma.o: In function `rdma_request': >> > trans_rdma.c:(.text+0x7bc): undefined reference to `rdma_disconnect' >> > net/9p/trans_rdma.o: In function `rdma_destroy_trans': >> > trans_rdma.c:(.text+0x830): undefined reference to `ib_destroy_qp' >> > trans_rdma.c:(.text+0x858): undefined reference to `ib_dealloc_pd' >> > Fixes: 9533b292a7ac ("IB: remove redundant INFINIBAND kconfig >> dependencies") >> > Signed-off-by: Arnd Bergmann >> Acked-by: Greg Thelen >> Sorry for the 9533b292a7ac problem. >> At this point the in release cycle, I think Arnd's revert is best. >> If there is interest, I've put a little thought into an alternative fix: >> making INFINIBAND_ADDR_TRANS tristate. But it's nontrivial. >> So I prefer this simple revert for now. > Is that a normal thing to do? For me: no, it's not normal. In my use case I merely want to disable INFINIBAND_ADDR_TRANS while continuing to use INFINIBAND. This is supported with f7cb7b85be55 ("IB: make INFINIBAND_ADDR_TRANS configurable"). During f7cb7b85be55 development https://lkml.org/lkml/2018/4/30/1073 suggested that we drop dependency on both INFINIBAND and INFINIBAND_ADDR_TRANS. Thus 9533b292a7ac ("IB: remove redundant INFINIBAND kconfig dependencies"). But 9533b292a7ac led to the randconfig build errors reported and thus ("IB: Revert "remove redundant INFINIBAND kconfig dependencies""). So I see no need to do anything more than apply ("IB: Revert "remove redundant INFINIBAND kconfig dependencies""). >> Doug: do you need anything from me on this? > I can take the revert.. > Jason Thanks.