From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH 11/25] block: add a REQ_UNMAP flag for REQ_OP_WRITE_ZEROES Date: Wed, 05 Apr 2017 07:46:55 -0400 Message-ID: References: <20170331163313.31821-1-hch@lst.de> <20170331163313.31821-12-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170331163313.31821-12-hch-jcswGhMUV9g@public.gmane.org> (Christoph Hellwig's message of "Fri, 31 Mar 2017 18:32:59 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: Christoph Hellwig Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org, shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org List-Id: linux-raid.ids Christoph Hellwig writes: > If this flag is set logical provisioning capable device should > release space for the zeroed blocks if possible, if it is not set > devices should keep the blocks anchored. > > Also remove an out of sync kerneldoc comment for a static function > that would have become even more out of data with this change. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: Christoph Hellwig Cc: axboe@kernel.dk, martin.petersen@oracle.com, agk@redhat.com, snitzer@redhat.com, shli@kernel.org, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, drbd-dev@lists.linbit.com, dm-devel@redhat.com, linux-raid@vger.kernel.org Subject: Re: [PATCH 11/25] block: add a REQ_UNMAP flag for REQ_OP_WRITE_ZEROES From: "Martin K. Petersen" References: <20170331163313.31821-1-hch@lst.de> <20170331163313.31821-12-hch@lst.de> Date: Wed, 05 Apr 2017 07:46:55 -0400 In-Reply-To: <20170331163313.31821-12-hch@lst.de> (Christoph Hellwig's message of "Fri, 31 Mar 2017 18:32:59 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-ID: Christoph Hellwig writes: > If this flag is set logical provisioning capable device should > release space for the zeroed blocks if possible, if it is not set > devices should keep the blocks anchored. > > Also remove an out of sync kerneldoc comment for a static function > that would have become even more out of data with this change. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering