From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Arun Easi <aeasi@marvell.com>,
Martin Petersen <martin.petersen@oracle.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
James Bottomley <jejb@linux.ibm.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-next@vger.kernel.org>,
<GR-QLogic-Storage-Upstream@marvell.com>
Subject: Re: [PATCH v3 1/1] tracing: Fix compile error in trace_array calls when TRACING is disabled
Date: Thu, 15 Sep 2022 21:32:59 -0400 [thread overview]
Message-ID: <yq15yho3y0s.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220907233308.4153-2-aeasi@marvell.com> (Arun Easi's message of "Wed, 7 Sep 2022 16:33:08 -0700")
Steven,
Can you please review Arun's patch?
> Fix this compilation error seen when CONFIG_TRACING is not enabled:
>
> drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_init':
> drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function
> 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'?
> [-Werror=implicit-function-declaration]
> 2854 | qla_trc_array = trace_array_get_by_name("qla2xxx");
> | ^~~~~~~~~~~~~~~~~~~~~~~
> | trace_array_set_clr_event
>
> drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_uninit':
> drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function
> 'trace_array_put' [-Werror=implicit-function-declaration]
> 2869 | trace_array_put(qla_trc_array);
> | ^~~~~~~~~~~~~~~
>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-09-16 1:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 23:33 [PATCH v3 0/1] Tracing: Compile error with qla2xxx Arun Easi
2022-09-07 23:33 ` [PATCH v3 1/1] tracing: Fix compile error in trace_array calls when TRACING is disabled Arun Easi
2022-09-08 16:55 ` Bart Van Assche
2022-09-08 19:12 ` [EXT] " Arun Easi
2022-09-16 1:32 ` Martin K. Petersen [this message]
2022-09-16 21:22 ` Arun Easi
2022-09-22 21:02 ` Steven Rostedt
2022-09-22 22:34 ` [EXT] " Arun Easi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq15yho3y0s.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=aeasi@marvell.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.