From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B055DC2BA2B for ; Tue, 14 Apr 2020 02:22:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AECA20768 for ; Tue, 14 Apr 2020 02:22:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="uW9TyVK0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404080AbgDNCWs (ORCPT ); Mon, 13 Apr 2020 22:22:48 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:35188 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404055AbgDNCWr (ORCPT ); Mon, 13 Apr 2020 22:22:47 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03E2JJN1196451; Tue, 14 Apr 2020 02:22:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2020-01-29; bh=OD928EEDzTdPfGhJ/G5hF78+rayv6LqnjaUq8/M5Zkk=; b=uW9TyVK0OgTKTCrK1SvksWbKZqzYUk27oPQ3oworxBGGqu/B2VRDHs/pz9OvfnXbWMCj 94oe2GryZQj3tvqvYtZ6jOBIIGbV+BXB/y9NamXi5yVOAuJXyEZnAZTWYFNt4u9qb6Hj EFqi/fhKXphquu+cfG/luEk5ySbYEVp0rUQAlTS9X7tBslSj59fZyqOAQLckTvPv4AaR 5m6vqy35Llu2EaOcLpdEM+PlzIq9XS6IemuprHlIHxXN3bc/Ymiwr+NhWmPhdr1QX8m+ IwM+0Quu5OOBkHfPDhxy/HD56ahtzyK51Lx9Gx7eKLxNECveEWPIy1qFKlUWlUSpKbyr Xg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 30b6hphqka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Apr 2020 02:22:35 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03E2Lh9S143278; Tue, 14 Apr 2020 02:22:35 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 30bqcg1p0n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Apr 2020 02:22:35 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 03E2MX0E000300; Tue, 14 Apr 2020 02:22:33 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 13 Apr 2020 19:22:33 -0700 To: Bart Van Assche Cc: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, Nilesh Javali , Himanshu Madhani , Quinn Tran , Martin Wilck , Daniel Wagner , Roman Bolshakov Subject: Re: [PATCH] qla2xxx: Split qla2x00_configure_local_loop() From: "Martin K. Petersen" Organization: Oracle Corporation References: <20200405225905.17171-1-bvanassche@acm.org> Date: Mon, 13 Apr 2020 22:22:30 -0400 In-Reply-To: <20200405225905.17171-1-bvanassche@acm.org> (Bart Van Assche's message of "Sun, 5 Apr 2020 15:59:05 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9590 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=953 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004140018 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9590 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 mlxlogscore=999 clxscore=1011 mlxscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004140017 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Bart, > The size of the function qla2x00_configure_local_loop() hurts its > readability. Hence split that function. This patch does not change any > functionality. Applied to 5.8/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering