All of
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <>
To: Guenter Roeck <>
Cc: "Martin K . Petersen" <>,,,, Hou Pu <>,
	Mike Christie <>
Subject: Re: [PATCH] scsi: target: iscsi: Drop unnecessary container_of
Date: Fri, 14 May 2021 22:42:08 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Guenter Roeck's message of "Sun, 9 May 2021 21:08:17 -0700")


> The structure pointer passed to container_of() is never NULL; that was
> already checked. That means that the result of container_of()
> operations on it is also never NULL, even though se_node_acl is the
> first element of the structure embedding it. On top of that, it is
> misleading to perform a NULL check on the result of container_of()
> because the position of the contained element could change, which
> would make the test invalid.  Remove the unnecessary NULL check.

Applied to 5.14/scsi-staging, thanks!

Martin K. Petersen	Oracle Linux Engineering

      reply	other threads:[~2021-05-15  2:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10  4:08 Guenter Roeck
2021-05-15  2:42 ` Martin K. Petersen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] scsi: target: iscsi: Drop unnecessary container_of' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.