From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Shai Malin <smalin@marvell.com>,
linux-scsi@vger.kernel.org,
GR-QLogic-Storage-Upstream@marvell.com, malin1024@gmail.com,
Manish Rangankar <mrangankar@marvell.com>
Subject: Re: [PATCH v2] scsi: qedi: Add support for fastpath doorvell recovery
Date: Wed, 11 Aug 2021 22:52:43 -0400 [thread overview]
Message-ID: <yq18s17tlwe.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20210811154725.GA1122984@roeck-us.net> (Guenter Roeck's message of "Wed, 11 Aug 2021 08:47:25 -0700")
Guenter,
>> rval = qedi_ops->offload_conn(qedi->cdev, qedi_ep->handle, conn_info);
>> if (rval)
>> + /* delete doorbell from doorbell recovery mechanism */
>> + rval = qedi_ops->common->db_recovery_del(qedi->cdev,
>> + qedi_ep->p_doorbell,
>> + &qedi_ep->db_data);
>> +
>> QEDI_ERR(&qedi->dbg_ctx, "offload_conn returned %d, ep=%p\n",
>> rval, qedi_ep);
>
> Due to missing { } this will now always result in QEDI_ERR() execution
> (and possibly a C compiler warning).
Fixed up. Thanks for spotting!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-08-12 2:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 22:14 [PATCH v2] scsi: qedi: Add support for fastpath doorvell recovery Shai Malin
2021-08-10 3:56 ` Martin K. Petersen
2021-08-11 15:47 ` Guenter Roeck
2021-08-12 2:52 ` Martin K. Petersen [this message]
2021-08-17 3:17 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18s17tlwe.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=malin1024@gmail.com \
--cc=mrangankar@marvell.com \
--cc=smalin@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.