From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Coly Li <colyli@suse.de>,
linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
linux-kernel@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
Xiao Ni <xni@redhat.com>, Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@lst.de>,
Enzo Matsumiya <ematsumiya@suse.com>,
Jens Axboe <axboe@kernel.dk>, Evan Green <evgreen@chromium.org>
Subject: Re: [PATCH] block: tolerate 0 byte discard_granularity in __blkdev_issue_discard()
Date: Tue, 04 Aug 2020 20:28:28 -0400 [thread overview]
Message-ID: <yq18seu0wdd.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20200804235811.GA1981569@T590> (Ming Lei's message of "Wed, 5 Aug 2020 07:58:11 +0800")
Ming,
> What we need to fix is loop driver, if it claims to support discard,
> q->limits.discard_granularity has to be one valid value.
Yep!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-08-05 0:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 14:23 [PATCH] block: tolerate 0 byte discard_granularity in __blkdev_issue_discard() Coly Li
2020-08-04 14:31 ` Johannes Thumshirn
2020-08-04 14:34 ` Coly Li
2020-08-04 14:37 ` Johannes Thumshirn
2020-08-04 14:39 ` Johannes Thumshirn
2020-08-04 14:45 ` Coly Li
2020-08-04 14:54 ` Johannes Thumshirn
2020-08-04 14:43 ` Coly Li
2020-08-04 23:58 ` Ming Lei
2020-08-05 0:28 ` Martin K. Petersen [this message]
2020-08-05 1:54 ` Coly Li
2020-08-05 2:46 ` Ming Lei
2020-08-05 2:52 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18seu0wdd.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=colyli@suse.de \
--cc=ematsumiya@suse.com \
--cc=evgreen@chromium.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.