From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF27C43382 for ; Fri, 28 Sep 2018 06:31:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA5672173D for ; Fri, 28 Sep 2018 06:31:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="o3F6cMXL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA5672173D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728916AbeI1MxM (ORCPT ); Fri, 28 Sep 2018 08:53:12 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:53676 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728062AbeI1MxL (ORCPT ); Fri, 28 Sep 2018 08:53:11 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w8S6STLH134756; Fri, 28 Sep 2018 06:30:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=6cEbswZ4WhObasNaEhN77uwwPfKwGM30NhrwD76U3Fk=; b=o3F6cMXLD1UFeV9+e3cikdzzet33ojbBg/zZclWAFo306E+9tfiN8mGXA3dYMrMIraKc S63vEwt0cFM+N10IaOQBbf9+O8j4FKyjoGKwwWrw8z/CQ4ITvryE762SzXYKuQI+kea1 4R+7CkUhDKJ3h7JttvfCbFOOVbadP7xOn9cOUwvRBmZlsZS5ceZvMNxn5zQp4iyzMUta jy+X875OrO2A/VZXMD18idAFDfrjRI+Vx3Qbr55gtGy1vy6x756jysWUAQh46rpNQZkH nBpGtmbCziqInp8J13305FeL51QNtwFtTfUbPd1if5b9iv3KVjDuaJoHoxtW7tX0lA1i pQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2mnd5tx3ab-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 Sep 2018 06:30:55 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w8S6UtgO005212 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 Sep 2018 06:30:55 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w8S6UsBv006260; Fri, 28 Sep 2018 06:30:54 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 27 Sep 2018 23:30:54 -0700 To: Colin King Cc: QLogic-Storage-Upstream@qlogic.com, "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: qla4xxx: remove redundant check on drvr_wait From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180926130848.30645-1-colin.king@canonical.com> Date: Fri, 28 Sep 2018 02:30:51 -0400 In-Reply-To: <20180926130848.30645-1-colin.king@canonical.com> (Colin King's message of "Wed, 26 Sep 2018 14:08:48 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9029 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=729 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809280070 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > The check for a non-zero drvr_wait is redundant as the same check is > performed earlier in the outer while loop, the inner check will always > be true if we reached this point inside the while loop. Remove the > redundant if check. Applied to 4.20/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Fri, 28 Sep 2018 06:30:51 +0000 Subject: Re: [PATCH] scsi: qla4xxx: remove redundant check on drvr_wait Message-Id: List-Id: References: <20180926130848.30645-1-colin.king@canonical.com> In-Reply-To: <20180926130848.30645-1-colin.king@canonical.com> (Colin King's message of "Wed, 26 Sep 2018 14:08:48 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: QLogic-Storage-Upstream@qlogic.com, "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin, > The check for a non-zero drvr_wait is redundant as the same check is > performed earlier in the outer while loop, the inner check will always > be true if we reached this point inside the while loop. Remove the > redundant if check. Applied to 4.20/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering