From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: Kees Cook Cc: Jens Axboe , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Sagar Dharia , Randy Dunlap , Vinod Koul , David Kershner , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/9] block: Consolidate scsi sense buffer usage From: "Martin K. Petersen" References: <20180731195155.46664-1-keescook@chromium.org> Date: Thu, 02 Aug 2018 16:21:28 -0400 In-Reply-To: <20180731195155.46664-1-keescook@chromium.org> (Kees Cook's message of "Tue, 31 Jul 2018 12:51:45 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-ID: Kees, > This is a follow-up to commit f7068114d45e ("sr: pass down correctly > sized SCSI sense buffer") which further cleans up and removes needless > sense character array buffers and "struct request_sense" usage in favor > of the common "struct scsi_sense_hdr". This looks good to me. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH v2 0/9] block: Consolidate scsi sense buffer usage Date: Thu, 02 Aug 2018 16:21:28 -0400 Message-ID: References: <20180731195155.46664-1-keescook@chromium.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20180731195155.46664-1-keescook@chromium.org> (Kees Cook's message of "Tue, 31 Jul 2018 12:51:45 -0700") Sender: linux-kernel-owner@vger.kernel.org To: Kees Cook Cc: Jens Axboe , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= List-Id: linux-ide@vger.kernel.org Kees, > This is a follow-up to commit f7068114d45e ("sr: pass down correctly > sized SCSI sense buffer") which further cleans up and removes needless > sense character array buffers and "struct request_sense" usage in favor > of the common "struct scsi_sense_hdr". This looks good to me. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Thu, 02 Aug 2018 20:21:28 +0000 Subject: Re: [PATCH v2 0/9] block: Consolidate scsi sense buffer usage Message-Id: List-Id: References: <20180731195155.46664-1-keescook@chromium.org> In-Reply-To: <20180731195155.46664-1-keescook@chromium.org> (Kees Cook's message of "Tue, 31 Jul 2018 12:51:45 -0700") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kees Cook Cc: Jens Axboe , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Sagar Dharia , Randy Dunlap , Vinod Koul , David Kershner , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Kees, > This is a follow-up to commit f7068114d45e ("sr: pass down correctly > sized SCSI sense buffer") which further cleans up and removes needless > sense character array buffers and "struct request_sense" usage in favor > of the common "struct scsi_sense_hdr". This looks good to me. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering