From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Always retry internal target error
Date: Tue, 17 Oct 2017 22:58:00 -0400 [thread overview]
Message-ID: <yq18tg9upqf.fsf@oracle.com> (raw)
In-Reply-To: <1508224263-130302-1-git-send-email-hare@suse.de> (Hannes Reinecke's message of "Tue, 17 Oct 2017 09:11:03 +0200")
Hannes,
> + if (!strncmp(scmd->device->vendor, "EMC", 3) &&
> + !strncmp(scmd->device->model, "SYMMETRIX", 9) &&
> + (sshdr.asc == 0x44) && (sshdr.ascq == 0x0)) {
> + /*
> + * EMC Symmetrix returns 'Internal target failure'
> + * for a variety of internal issues, all of which
> + * can be recovered by retry.
> + */
> + return ADD_TO_MLQUEUE;
> + }
It's decidedly awful to have vendor/model-specific triggers in
scsi_error.
What are the drawbacks of just always refiring on AC/0x44/ITF?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-10-18 2:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 7:11 [PATCH] scsi: Always retry internal target error Hannes Reinecke
2017-10-18 2:58 ` Martin K. Petersen [this message]
2017-10-18 6:15 ` Hannes Reinecke
2017-10-18 6:34 ` Christoph Hellwig
2017-10-18 7:27 ` Hannes Reinecke
2018-01-10 16:54 ` Xose Vazquez Perez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18tg9upqf.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.