From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754181AbcIILMk (ORCPT ); Fri, 9 Sep 2016 07:12:40 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:41257 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753966AbcIILMi (ORCPT ); Fri, 9 Sep 2016 07:12:38 -0400 To: Baoyou Xie Cc: QLogic-Storage-Upstream@qlogic.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn Subject: Re: [PATCH] [SCSI] bnx2fc: mark symbols static where possible From: "Martin K. Petersen" Organization: Oracle Corporation References: <1472971941-4882-1-git-send-email-baoyou.xie@linaro.org> Date: Fri, 09 Sep 2016 07:12:25 -0400 In-Reply-To: <1472971941-4882-1-git-send-email-baoyou.xie@linaro.org> (Baoyou Xie's message of "Sun, 4 Sep 2016 14:52:21 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Baoyou" == Baoyou Xie writes: Baoyou> We get a few warnings when building kernel with W=1: Baoyou> drivers/scsi/bnx2fc/bnx2fc_els.c:257:6: warning: no previous Baoyou> prototype for 'bnx2fc_srr_compl' [-Wmissing-prototypes] Baoyou> drivers/scsi/bnx2fc/bnx2fc_els.c:367:6: warning: no previous Baoyou> prototype for 'bnx2fc_rec_compl' [-Wmissing-prototypes] Baoyou> drivers/scsi/bnx2fc/bnx2fc_fcoe.c:628:5: warning: no previous Baoyou> prototype for 'bnx2fc_percpu_io_thread' [-Wmissing-prototypes] Baoyou> drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1413:26: warning: no previous Baoyou> prototype for 'bnx2fc_interface_create' [-Wmissing-prototypes] Baoyou> drivers/scsi/bnx2fc/bnx2fc_hwi.c:997:21: warning: no previous Baoyou> prototype for 'bnx2fc_alloc_work' [-Wmissing-prototypes] Baoyou> drivers/scsi/bnx2fc/bnx2fc_io.c:1082:5: warning: no previous Baoyou> prototype for 'bnx2fc_abts_cleanup' [-Wmissing-prototypes] .... Baoyou> In fact, these functions are only used in the file in which they Baoyou> are declared and don't need a declaration, but can be made Baoyou> static. so this patch marks these functions with 'static'. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering