From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com,
sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com,
suganath-prabu.subramani@broadcom.com,
sreekanth.reddy@broadcom.com, brking@linux.vnet.ibm.com,
mauricfo@linux.vnet.ibm.com, linuxram@us.ibm.com
Subject: Re: [PATCH v2] mpt3sas: Force request partial completion alignment
Date: Wed, 25 Jan 2017 18:46:13 -0500 [thread overview]
Message-ID: <yq1a8aebt4q.fsf@oracle.com> (raw)
In-Reply-To: <1485272838-23180-1-git-send-email-gpiccoli@linux.vnet.ibm.com> (Guilherme G. Piccoli's message of "Tue, 24 Jan 2017 13:47:18 -0200")
>>>>> "Guilherme" == Guilherme G Piccoli <gpiccoli@linux.vnet.ibm.com> writes:
Hi Guilherme,
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 75f3fce..e52c942 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -4657,6 +4657,8 @@ _scsih_io_done(struct MPT3SAS_ADAPTER *ioc, u16 smid, u8 msix_index, u32 reply)
struct MPT3SAS_DEVICE *sas_device_priv_data;
u32 response_code = 0;
unsigned long flags;
+ unsigned int sector_sz;
+ struct request *req;
mpi_reply = mpt3sas_base_get_reply_virt_addr(ioc, reply);
scmd = _scsih_scsi_lookup_get_clear(ioc, smid);
@@ -4715,6 +4717,21 @@ _scsih_io_done(struct MPT3SAS_ADAPTER *ioc, u16 smid, u8 msix_index, u32 reply)
}
xfer_cnt = le32_to_cpu(mpi_reply->TransferCount);
+
+ /* In case of bogus fw or device, we could end up having
+ * unaligned partial completion. We can force alignment here,
+ * then scsi-ml does not need to handle this misbehavior.
+ */
+ sector_sz = scmd->device->sector_size;
+ req = scmd->request;
+ if (unlikely(sector_sz && req && (req->cmd_type == REQ_TYPE_FS) &&
+ (xfer_cnt % sector_sz))) {
Maybe a bit zealous on the sanity checking...
+ sdev_printk(KERN_INFO, scmd->device,
+ "unaligned partial completion avoided (xfer_cnt=%u, sector_sz=%u)\n",
+ xfer_cnt, sector_sz);
+ xfer_cnt = (xfer_cnt / sector_sz) * sector_sz;
Not so keen on divisions. xfer_cnt = round_down(xfer_cnt, sector_sz), maybe?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-01-25 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 15:47 [PATCH v2] mpt3sas: Force request partial completion alignment Guilherme G. Piccoli
2017-01-25 4:46 ` Sreekanth Reddy
2017-01-25 23:46 ` Martin K. Petersen [this message]
2017-01-26 13:31 ` Guilherme G. Piccoli
2017-01-26 17:02 ` Ram Pai
2017-01-26 18:37 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1a8aebt4q.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=brking@linux.vnet.ibm.com \
--cc=chaitra.basappa@broadcom.com \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=mauricfo@linux.vnet.ibm.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.