* [PATCH] MAINTAINERS: Add mpi3mr driver maintainers @ 2021-06-23 7:21 Sreekanth Reddy 2021-06-23 7:21 ` [PATCH] mpi3mr: Fix W=1 compilation warnings Sreekanth Reddy 0 siblings, 1 reply; 4+ messages in thread From: Sreekanth Reddy @ 2021-06-23 7:21 UTC (permalink / raw) To: linux-scsi, martin.petersen Cc: jejb, mpi3mr-linuxdrv.pdl, kashyap.desai, sathya.prakash, Sreekanth Reddy [-- Attachment #1: Type: text/plain, Size: 947 bytes --] Adding mpi3mr driver entry. Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com> --- MAINTAINERS | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 529bdc6c44ad..323fee8a3df4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3733,6 +3733,17 @@ S: Supported F: Documentation/devicetree/bindings/gpio/brcm,kona-gpio.txt F: drivers/gpio/gpio-bcm-kona.c +BROADCOM MPI3 STORAGE CONTROLLER DRIVER +M: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com> +M: Kashyap Desai <kashyap.desai@broadcom.com> +M: Sumit Saxena <sumit.saxena@broadcom.com> +M: Sreekanth Reddy <sreekanth.reddy@broadcom.com> +L: mpi3mr-linuxdrv.pdl@broadcom.com +L: linux-scsi@vger.kernel.org +S: Supported +W: https://www.broadcom.com/support/storage +F: drivers/scsi/mpi3mr/ + BROADCOM NETXTREME-E ROCE DRIVER M: Selvin Xavier <selvin.xavier@broadcom.com> M: Devesh Sharma <devesh.sharma@broadcom.com> -- 2.27.0 [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4218 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mpi3mr: Fix W=1 compilation warnings 2021-06-23 7:21 [PATCH] MAINTAINERS: Add mpi3mr driver maintainers Sreekanth Reddy @ 2021-06-23 7:21 ` Sreekanth Reddy 2021-06-29 3:44 ` Martin K. Petersen 0 siblings, 1 reply; 4+ messages in thread From: Sreekanth Reddy @ 2021-06-23 7:21 UTC (permalink / raw) To: linux-scsi, martin.petersen Cc: jejb, mpi3mr-linuxdrv.pdl, kashyap.desai, sathya.prakash, Sreekanth Reddy, kernel test robot [-- Attachment #1: Type: text/plain, Size: 1488 bytes --] Fix for below W=1 compilation warning, 'strncpy' output may be truncated copying 16 bytes from a string of length 64 Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com> --- drivers/scsi/mpi3mr/mpi3mr_fw.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c index 9eceafca59bc..fd437a19b948 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_fw.c +++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c @@ -2608,10 +2608,8 @@ static int mpi3mr_issue_iocinit(struct mpi3mr_ioc *mrioc) } drv_info->information_length = cpu_to_le32(data_len); strncpy(drv_info->driver_signature, "Broadcom", sizeof(drv_info->driver_signature)); - strncpy(drv_info->os_name, utsname()->sysname, sizeof(drv_info->os_name)); - drv_info->os_name[sizeof(drv_info->os_name) - 1] = 0; - strncpy(drv_info->os_version, utsname()->release, sizeof(drv_info->os_version)); - drv_info->os_version[sizeof(drv_info->os_version) - 1] = 0; + memcpy(drv_info->os_name, utsname()->sysname, sizeof(drv_info->os_name) - 1); + memcpy(drv_info->os_version, utsname()->release, sizeof(drv_info->os_version) - 1); strncpy(drv_info->driver_name, MPI3MR_DRIVER_NAME, sizeof(drv_info->driver_name)); strncpy(drv_info->driver_version, MPI3MR_DRIVER_VERSION, sizeof(drv_info->driver_version)); strncpy(drv_info->driver_release_date, MPI3MR_DRIVER_RELDATE, sizeof(drv_info->driver_release_date)); -- 2.27.0 [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4218 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mpi3mr: Fix W=1 compilation warnings 2021-06-23 7:21 ` [PATCH] mpi3mr: Fix W=1 compilation warnings Sreekanth Reddy @ 2021-06-29 3:44 ` Martin K. Petersen 2021-06-29 14:08 ` Sreekanth Reddy 0 siblings, 1 reply; 4+ messages in thread From: Martin K. Petersen @ 2021-06-29 3:44 UTC (permalink / raw) To: Sreekanth Reddy Cc: linux-scsi, martin.petersen, jejb, mpi3mr-linuxdrv.pdl, kashyap.desai, sathya.prakash, kernel test robot Sreekanth, > - strncpy(drv_info->os_name, utsname()->sysname, sizeof(drv_info->os_name)); > - drv_info->os_name[sizeof(drv_info->os_name) - 1] = 0; > - strncpy(drv_info->os_version, utsname()->release, sizeof(drv_info->os_version)); > - drv_info->os_version[sizeof(drv_info->os_version) - 1] = 0; > + memcpy(drv_info->os_name, utsname()->sysname, sizeof(drv_info->os_name) - 1); > + memcpy(drv_info->os_version, utsname()->release, sizeof(drv_info->os_version) - 1); strscpy()? -- Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mpi3mr: Fix W=1 compilation warnings 2021-06-29 3:44 ` Martin K. Petersen @ 2021-06-29 14:08 ` Sreekanth Reddy 0 siblings, 0 replies; 4+ messages in thread From: Sreekanth Reddy @ 2021-06-29 14:08 UTC (permalink / raw) To: Martin K. Petersen Cc: linux-scsi, James E.J. Bottomley, mpi3mr-drvr-developers, Kashyap Desai, Sathya Prakash Veerichetty, kernel test robot [-- Attachment #1: Type: text/plain, Size: 735 bytes --] On Tue, Jun 29, 2021 at 9:14 AM Martin K. Petersen <martin.petersen@oracle.com> wrote: > > > Sreekanth, > > > - strncpy(drv_info->os_name, utsname()->sysname, sizeof(drv_info->os_name)); > > - drv_info->os_name[sizeof(drv_info->os_name) - 1] = 0; > > - strncpy(drv_info->os_version, utsname()->release, sizeof(drv_info->os_version)); > > - drv_info->os_version[sizeof(drv_info->os_version) - 1] = 0; > > + memcpy(drv_info->os_name, utsname()->sysname, sizeof(drv_info->os_name) - 1); > > + memcpy(drv_info->os_version, utsname()->release, sizeof(drv_info->os_version) - 1); > > strscpy()? Agreed. Posted a new patch using strscpy(). Thanks, Sreekanth > > -- > Martin K. Petersen Oracle Linux Engineering [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4218 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-29 14:08 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-23 7:21 [PATCH] MAINTAINERS: Add mpi3mr driver maintainers Sreekanth Reddy 2021-06-23 7:21 ` [PATCH] mpi3mr: Fix W=1 compilation warnings Sreekanth Reddy 2021-06-29 3:44 ` Martin K. Petersen 2021-06-29 14:08 ` Sreekanth Reddy
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.