From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Keita Suzuki <keitasuzuki.park@sslab.ics.keio.ac.jp>
Cc: takafumi@sslab.ics.keio.ac.jp,
Don Brace <don.brace@microsemi.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Kevin Barnett <kevin.barnett@microsemi.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Scott Teel <scott.teel@microsemi.com>,
esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2] scsi: hpsa: fix memory leak in hpsa_init_one
Date: Mon, 26 Oct 2020 17:49:04 -0400 [thread overview]
Message-ID: <yq1d0148xza.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20200930155100.11528-1-keitasuzuki.park@sslab.ics.keio.ac.jp> (Keita Suzuki's message of "Wed, 30 Sep 2020 15:50:59 +0000")
Keita,
> When hpsa_scsi_add_host fails, h->lastlogicals is leaked since it lacks
> free in the error handler.
>
> Fix this by adding free when hpsa_scsi_add_host fails.
>
> This patch also renames the numbered labels to detailed names.
While I am no fan of numbered labels, these initialization stages are
referenced several other places in the driver. As a result, renaming the
labels makes the rest of the code harder to follow.
I suggest you submit a fix for just the leak. And then, if the hpsa
maintainers agree, we can entertain a separate patch to improve the
naming.
Thank you!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-10-26 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 15:50 [RESEND PATCH v2] scsi: hpsa: fix memory leak in hpsa_init_one Keita Suzuki
2020-10-26 21:49 ` Martin K. Petersen [this message]
2020-10-27 1:22 ` Keita Suzuki
2020-10-27 7:31 ` [PATCH v3] " Keita Suzuki
2020-10-27 15:27 ` Don.Brace
2020-10-30 2:20 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d0148xza.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=don.brace@microsemi.com \
--cc=esc.storagedev@microsemi.com \
--cc=jejb@linux.ibm.com \
--cc=jthumshirn@suse.de \
--cc=keitasuzuki.park@sslab.ics.keio.ac.jp \
--cc=kevin.barnett@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=scott.teel@microsemi.com \
--cc=takafumi@sslab.ics.keio.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.