All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
	target-devel@vger.kernel.org, linux-rdma@vger.kernel.org,
	Rahul Kundu <rahul.kundu@chelsio.com>
Subject: Re: [PATCH] RDMA/isert: Fix a recently introduced regression related to logout
Date: Tue, 21 Jan 2020 00:30:53 -0500	[thread overview]
Message-ID: <yq1d0bdidf6.fsf@oracle.com> (raw)
In-Reply-To: <20200116044737.19507-1-bvanassche@acm.org> (Bart Van Assche's message of "Wed, 15 Jan 2020 20:47:37 -0800")


Bart,

> iscsit_close_connection() calls isert_wait_conn(). Due to commit
> e9d3009cb936 both functions call target_wait_for_sess_cmds() although
> that last function should be called only once. Fix this by removing
> the target_wait_for_sess_cmds() call from isert_wait_conn() and by
> only calling isert_wait_conn() after target_wait_for_sess_cmds().

Applied to 5.5/scsi-fixes, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
	target-devel@vger.kernel.org, linux-rdma@vger.kernel.org,
	Rahul Kundu <rahul.kundu@chelsio.com>
Subject: Re: [PATCH] RDMA/isert: Fix a recently introduced regression related to logout
Date: Tue, 21 Jan 2020 05:30:53 +0000	[thread overview]
Message-ID: <yq1d0bdidf6.fsf@oracle.com> (raw)
In-Reply-To: <20200116044737.19507-1-bvanassche@acm.org> (Bart Van Assche's message of "Wed, 15 Jan 2020 20:47:37 -0800")


Bart,

> iscsit_close_connection() calls isert_wait_conn(). Due to commit
> e9d3009cb936 both functions call target_wait_for_sess_cmds() although
> that last function should be called only once. Fix this by removing
> the target_wait_for_sess_cmds() call from isert_wait_conn() and by
> only calling isert_wait_conn() after target_wait_for_sess_cmds().

Applied to 5.5/scsi-fixes, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2020-01-21  5:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16  4:47 [PATCH] RDMA/isert: Fix a recently introduced regression related to logout Bart Van Assche
2020-01-16  4:47 ` Bart Van Assche
2020-01-17 16:42 ` Marciniszyn, Mike
2020-01-20  7:30 ` Sagi Grimberg
2020-01-20  7:30   ` Sagi Grimberg
2020-01-21  5:30 ` Martin K. Petersen [this message]
2020-01-21  5:30   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1d0bdidf6.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=bvanassche@acm.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rahul.kundu@chelsio.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.