* [PATCH] scsi: lpfc: remove redundant code
@ 2019-08-08 1:35 ` Fuqian Huang
0 siblings, 0 replies; 4+ messages in thread
From: Fuqian Huang @ 2019-08-08 1:35 UTC (permalink / raw)
Cc: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, linux-kernel, Fuqian Huang
Remove the redundant initialization code.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
drivers/scsi/lpfc/lpfc_bsg.c | 1 -
drivers/scsi/lpfc/lpfc_sli.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index b7216d694bff..5f66a2da2599 100644
--- a/drivers/scsi/lpfc/lpfc_bsg.c
+++ b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -1571,7 +1571,6 @@ lpfc_issue_ct_rsp(struct lpfc_hba *phba, struct bsg_job *job, uint32_t tag,
"2722 Xmit CT response on exchange x%x Data: x%x x%x x%x\n",
icmd->ulpContext, icmd->ulpIoTag, tag, phba->link_state);
- ctiocb->iocb_cmpl = NULL;
ctiocb->iocb_flag |= LPFC_IO_LIBDFC;
ctiocb->vport = phba->pport;
ctiocb->context1 = dd_data;
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index f9e6a135d656..156224c14cc7 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -17445,7 +17445,6 @@ lpfc_sli4_seq_abort_rsp(struct lpfc_vport *vport,
icmd->ulpContext = phba->sli4_hba.rpi_ids[ndlp->nlp_rpi];
ctiocb->context1 = lpfc_nlp_get(ndlp);
- ctiocb->iocb_cmpl = NULL;
ctiocb->vport = phba->pport;
ctiocb->iocb_cmpl = lpfc_sli4_seq_abort_rsp_cmpl;
ctiocb->sli4_lxritag = NO_XRI;
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] scsi: lpfc: remove redundant code
@ 2019-08-08 1:35 ` Fuqian Huang
0 siblings, 0 replies; 4+ messages in thread
From: Fuqian Huang @ 2019-08-08 1:35 UTC (permalink / raw)
Cc: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, linux-kernel, Fuqian Huang
Remove the redundant initialization code.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
drivers/scsi/lpfc/lpfc_bsg.c | 1 -
drivers/scsi/lpfc/lpfc_sli.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index b7216d694bff..5f66a2da2599 100644
--- a/drivers/scsi/lpfc/lpfc_bsg.c
+++ b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -1571,7 +1571,6 @@ lpfc_issue_ct_rsp(struct lpfc_hba *phba, struct bsg_job *job, uint32_t tag,
"2722 Xmit CT response on exchange x%x Data: x%x x%x x%x\n",
icmd->ulpContext, icmd->ulpIoTag, tag, phba->link_state);
- ctiocb->iocb_cmpl = NULL;
ctiocb->iocb_flag |= LPFC_IO_LIBDFC;
ctiocb->vport = phba->pport;
ctiocb->context1 = dd_data;
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index f9e6a135d656..156224c14cc7 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -17445,7 +17445,6 @@ lpfc_sli4_seq_abort_rsp(struct lpfc_vport *vport,
icmd->ulpContext = phba->sli4_hba.rpi_ids[ndlp->nlp_rpi];
ctiocb->context1 = lpfc_nlp_get(ndlp);
- ctiocb->iocb_cmpl = NULL;
ctiocb->vport = phba->pport;
ctiocb->iocb_cmpl = lpfc_sli4_seq_abort_rsp_cmpl;
ctiocb->sli4_lxritag = NO_XRI;
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: lpfc: remove redundant code
2019-08-08 1:35 ` Fuqian Huang
(?)
@ 2019-08-16 19:56 ` James Smart
-1 siblings, 0 replies; 4+ messages in thread
From: James Smart @ 2019-08-16 19:56 UTC (permalink / raw)
To: Fuqian Huang
Cc: Dick Kennedy, James E . J . Bottomley, Martin K . Petersen,
linux-scsi, linux-kernel
On 8/7/2019 6:35 PM, Fuqian Huang wrote:
> Remove the redundant initialization code.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
>
Looks good!
Reviewed-by: James Smart <james.smart@broadcom.com>
-- james
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: lpfc: remove redundant code
2019-08-08 1:35 ` Fuqian Huang
(?)
(?)
@ 2019-08-20 2:08 ` Martin K. Petersen
-1 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2019-08-20 2:08 UTC (permalink / raw)
To: Fuqian Huang; +Cc: linux-scsi
Fuqian,
> Remove the redundant initialization code.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-20 2:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08 1:35 [PATCH] scsi: lpfc: remove redundant code Fuqian Huang
2019-08-08 1:35 ` Fuqian Huang
2019-08-16 19:56 ` James Smart
2019-08-20 2:08 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.