From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751219AbdIEMZG (ORCPT ); Tue, 5 Sep 2017 08:25:06 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:38751 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbdIEMZD (ORCPT ); Tue, 5 Sep 2017 08:25:03 -0400 To: Arnd Bergmann Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Christoph Hellwig , Johannes Thumshirn , Hannes Reinicke , Finn Thain , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170905074956.469733-1-arnd@arndb.de> Date: Tue, 05 Sep 2017 08:24:40 -0400 In-Reply-To: <20170905074956.469733-1-arnd@arndb.de> (Arnd Bergmann's message of "Tue, 5 Sep 2017 09:49:23 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd, > Without CONFIG_BLK_DEV_BSGLIB, we get a link error here: > > drivers/scsi/scsi_transport_sas.o: In function `sas_bsg_initialize': > scsi_transport_sas.c:(.text+0xcc0): undefined reference to `bsg_setup_queue' > scsi_transport_sas.c:(.text+0xd10): undefined reference to `bsg_setup_queue' > drivers/scsi/scsi_transport_sas.o: In function `sas_smp_dispatch': > scsi_transport_sas.c:(.text+0xe8c): undefined reference to `bsg_job_done' > > This modifies the Kconfig 'select' statement accordingly, and matching > what we do for the other two scsi_transport implementations that use > bsglib. > > Fixes: 651a01364994 ("scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough") > Signed-off-by: Arnd Bergmann Applied to 4.14/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering