All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: wenxiong@linux.vnet.ibm.com
Cc: jejb@linux.ibm.com, linux-scsi@vger.kernel.org,
	brking1@linux.vnet.ibm.com, wenxiong@us.ibm.com
Subject: Re: [PATCH 1/1] scsi/ses: Saw "Failed to get diagnostic page 0x1" during
Date: Wed, 08 Sep 2021 00:12:56 -0400	[thread overview]
Message-ID: <yq1h7ev4t43.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <1629230255-11616-1-git-send-email-wenxiong@linux.vnet.ibm.com> (wenxiong@linux.vnet.ibm.com's message of "Tue, 17 Aug 2021 14:57:35 -0500")


Hi Wendy!

> From scsi logging level with error=3, looks ses_recv_diag not try on a
> UA.  Added scsi_test_unit_ready() which retried with UA. The patch
> fixes both of above errors.

As your own commit message indicates, scsi_recv_diag() does not retry on
Unit Attention. I would like to see a fix which addresses that
deficiency in general and not just during the first invocation.

I suggest you modify scsi_recv_diag() to retry the RECEIVE DIAGNOSTIC
operation after getting a transient error.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

      reply	other threads:[~2021-09-08  4:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 19:57 [PATCH 1/1] scsi/ses: Saw "Failed to get diagnostic page 0x1" during wenxiong
2021-09-08  4:12 ` Martin K. Petersen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1h7ev4t43.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=brking1@linux.vnet.ibm.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=wenxiong@linux.vnet.ibm.com \
    --cc=wenxiong@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.