From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F5DC43331 for ; Fri, 27 Mar 2020 17:05:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83F2C206F2 for ; Fri, 27 Mar 2020 17:05:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="x4GRhdLT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727796AbgC0RFH (ORCPT ); Fri, 27 Mar 2020 13:05:07 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:36902 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726333AbgC0RFG (ORCPT ); Fri, 27 Mar 2020 13:05:06 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02RGrUN7167850; Fri, 27 Mar 2020 17:04:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2020-01-29; bh=2uSk5OmF7Is8u+ylzJyfXZPzvaBYULTp/WZBWkL3rbo=; b=x4GRhdLT20y/KfX33gRdU9TWV63b9LlKIKi007etL+l23nhyRDc/1A0pQcAiSlecM+5h EnvTwNGd/j6GozwGvLETzWjZHxub7Hh6Gd4mQGum2lRMCP53bWsl0p0PE424sMLGdqtr vYw+uVckIktqjGt6wQUXKeRhseWQRo9UsfJIXYhGv07YiBVyUAwH9GDwllU196WTTysc vy3AV8YFvVTdnw/YBIDMzYUUkGJMRYP8jSD00T3X9jS929M0tGE9Kzp0Wp/dP6ikl+b1 RgC9/0to3zQlwrsk3/JxGTRqAuxeJri8mcsnUX++AbBAHGUHYuc5zbk+wIlyffCOJ7PR 2w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 301459c9e8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Mar 2020 17:04:43 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02RGr57S113183; Fri, 27 Mar 2020 17:04:42 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 30073h7308-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Mar 2020 17:04:42 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02RH4c6j005514; Fri, 27 Mar 2020 17:04:39 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 27 Mar 2020 10:04:38 -0700 To: Can Guo Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Subhash Jadavani , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Bart Van Assche , Venkat Gopalakrishnan , Tomas Winkler , linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v6 1/2] scsi: ufs: Clean up ufshcd_scale_clks() and clock scaling error out path From: "Martin K. Petersen" Organization: Oracle Corporation References: <1585214742-5466-1-git-send-email-cang@codeaurora.org> <1585214742-5466-2-git-send-email-cang@codeaurora.org> Date: Fri, 27 Mar 2020 13:04:33 -0400 In-Reply-To: <1585214742-5466-2-git-send-email-cang@codeaurora.org> (Can Guo's message of "Thu, 26 Mar 2020 02:25:40 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9573 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 suspectscore=0 mlxscore=0 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003270146 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9573 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 impostorscore=0 mlxscore=0 spamscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003270146 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Can, > This change introduces a func ufshcd_set_clk_freq() to explicitly set > clock frequency so that it can be used in reset_and_resotre path and > in ufshcd_scale_clks(). Meanwhile, this change cleans up the clock > scaling error out path. Applied to 5.7/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering