From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3132C282C4 for ; Tue, 5 Feb 2019 03:24:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7883820815 for ; Tue, 5 Feb 2019 03:24:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Z/qk+yQ8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726901AbfBEDY4 (ORCPT ); Mon, 4 Feb 2019 22:24:56 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:51164 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725855AbfBEDY4 (ORCPT ); Mon, 4 Feb 2019 22:24:56 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x153JMZe078878; Tue, 5 Feb 2019 03:24:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=ywPZWGGOvxrT5QRzVbV3PE2RKRB7A42Ek5IDY5apTYM=; b=Z/qk+yQ8i07ZjRJV+XxEUmSw3jGxUn98ABdoOR2EJTFVAAyt3BRH4WN00T0yWCguwYfN 8T9GMokfLn9h/s50T/RrbLjOJWzNqN1j9/e9peegDtIbNTxf2dNx4uYS2oQ90KdXGCw7 6g5KZLkGl+RHz9eOkAoGxaCWj+Eajx1PeYHVt/uAZObrGMlTJQUUWB6mEzwuVmBp+bSm wSm4LUvRxT+BazVFCHyhOSTyFp2QVRTc/rFcQs17p2adFJMdkaoPNbTs973mLEKFac9C 0PKB8/0kctxTFTojJE+LBjsceXz3KmGiuwy8vuaj4ZUzf5cTUhVSZI1v2qsSSSM06obt PQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2qd97ernyx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Feb 2019 03:24:43 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x153OgCF013387 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Feb 2019 03:24:42 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x153Ogba006825; Tue, 5 Feb 2019 03:24:42 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 05 Feb 2019 03:24:41 +0000 To: Vaibhav Jain Cc: "Manoj N . Kumar" , "Matthew R . Ochs" , Uma Krishnan , Frederic Barrat , linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org Subject: Re: [PATCH] scsi: cxlflash: Prevent deadlock when adapter probe fails From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190130122651.19255-1-vaibhav@linux.ibm.com> Date: Mon, 04 Feb 2019 22:24:37 -0500 In-Reply-To: <20190130122651.19255-1-vaibhav@linux.ibm.com> (Vaibhav Jain's message of "Wed, 30 Jan 2019 17:56:51 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9157 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=729 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902050024 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Vaibhav, > Presently when an error is encountered during probe of the cxlflash > adapter, a deadlock is seen with cpu thread stuck inside > cxlflash_remove(). Below is the trace of the deadlock as logged by > khungtaskd: Applied to 5.0/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E96FC282CB for ; Tue, 5 Feb 2019 03:26:36 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9AE720815 for ; Tue, 5 Feb 2019 03:26:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Z/qk+yQ8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9AE720815 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 43tqk14G8fzDqM9 for ; Tue, 5 Feb 2019 14:26:33 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=oracle.com (client-ip=141.146.126.79; helo=aserp2130.oracle.com; envelope-from=martin.petersen@oracle.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="Z/qk+yQ8"; dkim-atps=neutral Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43tqh61GPwzDqFF for ; Tue, 5 Feb 2019 14:24:47 +1100 (AEDT) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x153JMZe078878; Tue, 5 Feb 2019 03:24:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=ywPZWGGOvxrT5QRzVbV3PE2RKRB7A42Ek5IDY5apTYM=; b=Z/qk+yQ8i07ZjRJV+XxEUmSw3jGxUn98ABdoOR2EJTFVAAyt3BRH4WN00T0yWCguwYfN 8T9GMokfLn9h/s50T/RrbLjOJWzNqN1j9/e9peegDtIbNTxf2dNx4uYS2oQ90KdXGCw7 6g5KZLkGl+RHz9eOkAoGxaCWj+Eajx1PeYHVt/uAZObrGMlTJQUUWB6mEzwuVmBp+bSm wSm4LUvRxT+BazVFCHyhOSTyFp2QVRTc/rFcQs17p2adFJMdkaoPNbTs973mLEKFac9C 0PKB8/0kctxTFTojJE+LBjsceXz3KmGiuwy8vuaj4ZUzf5cTUhVSZI1v2qsSSSM06obt PQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2qd97ernyx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Feb 2019 03:24:43 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x153OgCF013387 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Feb 2019 03:24:42 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x153Ogba006825; Tue, 5 Feb 2019 03:24:42 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 05 Feb 2019 03:24:41 +0000 To: Vaibhav Jain Subject: Re: [PATCH] scsi: cxlflash: Prevent deadlock when adapter probe fails From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190130122651.19255-1-vaibhav@linux.ibm.com> Date: Mon, 04 Feb 2019 22:24:37 -0500 In-Reply-To: <20190130122651.19255-1-vaibhav@linux.ibm.com> (Vaibhav Jain's message of "Wed, 30 Jan 2019 17:56:51 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9157 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=729 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902050024 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Uma Krishnan , linux-scsi@vger.kernel.org, stable@vger.kernel.org, "Manoj N . Kumar" , Frederic Barrat , linuxppc-dev@lists.ozlabs.org, "Matthew R . Ochs" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Vaibhav, > Presently when an error is encountered during probe of the cxlflash > adapter, a deadlock is seen with cpu thread stuck inside > cxlflash_remove(). Below is the trace of the deadlock as logged by > khungtaskd: Applied to 5.0/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering