From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Ching Huang <ching2048@areca.com.tw>
Cc: martin.petersen@oracle.com,
James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
dan.carpenter@oracle.com, hch@infradead.org,
colin.king@canonical.com
Subject: Re: [PATCH 0/3] scsi: arcmsr: Add driver parameter cmd_timeout for scsi command timeout setting
Date: Tue, 08 May 2018 01:41:59 -0400 [thread overview]
Message-ID: <yq1in7ywvo8.fsf@oracle.com> (raw)
In-Reply-To: <1525675401.8876.9.camel@Centos6.3-64> (Ching Huang's message of "Mon, 07 May 2018 14:43:21 +0800")
Hello Ching,
> 1. Add driver parameter cmd_timeout, default value is ARCMSR_DEFAULT_TIMEOUT.
> 2. Add slave_configure callback function to set device command timeout value.
> 3. Update driver version to v1.40.00.06-20180504.
I am not so keen on arcmsr overriding the timeout set by the admin or
application.
Also, instead of introducing this module parameter, why not simply ask
the user to change rq_timeout?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-05-08 5:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 6:43 [PATCH 0/3] scsi: arcmsr: Add driver parameter cmd_timeout for scsi command timeout setting Ching Huang
2018-05-08 5:41 ` Martin K. Petersen [this message]
2018-05-08 6:32 ` Ching Huang
2018-05-08 6:43 ` Ching Huang
2018-05-09 9:05 ` Steffen Maier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1in7ywvo8.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ching2048@areca.com.tw \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.