From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH 02/18] md: cleanup bio op / flags handling in raid1_write_request Date: Wed, 25 Jan 2017 21:59:33 -0500 Message-ID: References: <1485365126-23210-1-git-send-email-hch@lst.de> <1485365126-23210-3-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1485365126-23210-3-git-send-email-hch@lst.de> (Christoph Hellwig's message of "Wed, 25 Jan 2017 18:25:10 +0100") Sender: linux-block-owner@vger.kernel.org To: Christoph Hellwig Cc: Jens Axboe , Mike Snitzer , Junichi Nomura , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-raid@vger.kernel.org, dm-devel@redhat.com List-Id: linux-raid.ids >>>>> "Christoph" == Christoph Hellwig writes: Christoph> No need for the local variables, the bio is still live and we Christoph> can just assigned the bits we want directly. Make me wonder Christoph> why we can't assign all the bio flags to start with. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering