From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Fri, 06 May 2016 01:23:53 +0000 Subject: Re: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling Message-Id: List-Id: References: <20160413111441.GC4247@mwanda> In-Reply-To: <20160413111441.GC4247@mwanda> (Dan Carpenter's message of "Wed, 13 Apr 2016 14:14:41 +0300") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Anil Gurumurthy , Sudarsana Kalluru , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org >>>>> "Dan" = Dan Carpenter writes: Dan> The caller assumes that "itnim" is NULL on error and non-NULL on Dan> success but really "itnim" is uninitialized on error. This Dan> function should just use normal error handling where it returns Dan> zero on success and negative on failure. Anil, please review: https://patchwork.kernel.org/patch/8820751/ -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling Date: Thu, 05 May 2016 21:23:53 -0400 Message-ID: References: <20160413111441.GC4247@mwanda> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20160413111441.GC4247@mwanda> (Dan Carpenter's message of "Wed, 13 Apr 2016 14:14:41 +0300") Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter Cc: Anil Gurumurthy , Sudarsana Kalluru , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-scsi@vger.kernel.org >>>>> "Dan" == Dan Carpenter writes: Dan> The caller assumes that "itnim" is NULL on error and non-NULL on Dan> success but really "itnim" is uninitialized on error. This Dan> function should just use normal error handling where it returns Dan> zero on success and negative on failure. Anil, please review: https://patchwork.kernel.org/patch/8820751/ -- Martin K. Petersen Oracle Linux Engineering