All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2 0/3] iscsi: chap: introduce support for SHA1, SHA256 and SHA3-256
@ 2019-10-17 13:10 Maurizio Lombardi
  2019-10-25  0:20 ` Martin K. Petersen
  2019-10-25  8:58 ` Maurizio Lombardi
  0 siblings, 2 replies; 3+ messages in thread
From: Maurizio Lombardi @ 2019-10-17 13:10 UTC (permalink / raw)
  To: target-devel

iSCSI with the Challenge-Handshake Authentication Protocol is not FIPS compliant.
This is due to the fact that CHAP currently uses MD5 as the only supported
digest algorithm and MD5 is not allowed by FIPS.

When FIPS mode is enabled on the target server, the CHAP authentication
won't work because the target driver will be prevented from using the MD5 module.

Given that CHAP is agnostic regarding the algorithm it uses, this
patchset introduce support for three new alternatives: SHA1, SHA256 and SHA3-256.

They all have their protocol identifiers assigned by IANA:
https://www.iana.org/assignments/ppp-numbers/ppp-numbers.xml#ppp-numbers-9

Initiator-side code for open-iscsi has already been merged:
https://github.com/open-iscsi/open-iscsi/pull/170

V2: adds SHA256

Maurizio Lombardi (3):
  target-iscsi: CHAP: add support to SHA1, SHA256 and SHA3-256 hash
    functions
  target-iscsi: tie the challenge length to the hash digest size
  target-iscsi: rename some variables to avoid confusion.

 drivers/target/iscsi/iscsi_target_auth.c | 232 +++++++++++++++--------
 drivers/target/iscsi/iscsi_target_auth.h |  17 +-
 2 files changed, 161 insertions(+), 88 deletions(-)

-- 
Maurizio Lombardi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH V2 0/3] iscsi: chap: introduce support for SHA1, SHA256 and SHA3-256
  2019-10-17 13:10 [PATCH V2 0/3] iscsi: chap: introduce support for SHA1, SHA256 and SHA3-256 Maurizio Lombardi
@ 2019-10-25  0:20 ` Martin K. Petersen
  2019-10-25  8:58 ` Maurizio Lombardi
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-10-25  0:20 UTC (permalink / raw)
  To: target-devel


Hi Maurizio,

> iSCSI with the Challenge-Handshake Authentication Protocol is not FIPS
> compliant.  This is due to the fact that CHAP currently uses MD5 as
> the only supported digest algorithm and MD5 is not allowed by FIPS.
>
> When FIPS mode is enabled on the target server, the CHAP
> authentication won't work because the target driver will be prevented
> from using the MD5 module.
>
> Given that CHAP is agnostic regarding the algorithm it uses, this
> patchset introduce support for three new alternatives: SHA1, SHA256
> and SHA3-256.

Can you please submit these on top of 5.5/scsi-queue which has your
string parsing fixes in place?

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH V2 0/3] iscsi: chap: introduce support for SHA1, SHA256 and SHA3-256
  2019-10-17 13:10 [PATCH V2 0/3] iscsi: chap: introduce support for SHA1, SHA256 and SHA3-256 Maurizio Lombardi
  2019-10-25  0:20 ` Martin K. Petersen
@ 2019-10-25  8:58 ` Maurizio Lombardi
  1 sibling, 0 replies; 3+ messages in thread
From: Maurizio Lombardi @ 2019-10-25  8:58 UTC (permalink / raw)
  To: target-devel

Hello,

Dne 25.10.2019 v 02:20 Martin K. Petersen napsal(a):
> 
> Hi Maurizio,
> 
>> iSCSI with the Challenge-Handshake Authentication Protocol is not FIPS
>> compliant.  This is due to the fact that CHAP currently uses MD5 as
>> the only supported digest algorithm and MD5 is not allowed by FIPS.
>>
>> When FIPS mode is enabled on the target server, the CHAP
>> authentication won't work because the target driver will be prevented
>> from using the MD5 module.
>>
>> Given that CHAP is agnostic regarding the algorithm it uses, this
>> patchset introduce support for three new alternatives: SHA1, SHA256
>> and SHA3-256.
> 
> Can you please submit these on top of 5.5/scsi-queue which has your
> string parsing fixes in place?
> 

I will rebase on top of 5.5/scsi-queue and send a V3.

Thanks,
Maurizio

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-25  8:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17 13:10 [PATCH V2 0/3] iscsi: chap: introduce support for SHA1, SHA256 and SHA3-256 Maurizio Lombardi
2019-10-25  0:20 ` Martin K. Petersen
2019-10-25  8:58 ` Maurizio Lombardi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.