From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:27218 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932305AbcKDQfd (ORCPT ); Fri, 4 Nov 2016 12:35:33 -0400 To: Hannes Reinecke Cc: Sreekanth Reddy , Igor Rybak , Andrey Grodzovsky , Ezra Kohavi , PDL-MPT-FUSIONLINUX , "linux-scsi\@vger.kernel.org" , Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , "stable\@vger.kernel.org" Subject: Re: [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v2) From: "Martin K. Petersen" References: <2179ecb8-183f-a500-4d65-10f64f0f43cc@suse.de> <1478045394-19536-1-git-send-email-andrey2805@gmail.com> <30w645ulbhlofxrk1h4a9q3s.1478144944778@email.android.com> <38e3e634-6e08-58bd-bc11-8a0a470b78d9@suse.de> Date: Fri, 04 Nov 2016 12:35:00 -0400 In-Reply-To: <38e3e634-6e08-58bd-bc11-8a0a470b78d9@suse.de> (Hannes Reinecke's message of "Fri, 4 Nov 2016 15:51:45 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org List-ID: >>>>> "Hannes" == Hannes Reinecke writes: Hannes> Checking with SAT-3 (section 6.2.4: Commands the SATL queues Hannes> internally) the implemented behaviour is standards conformant, Hannes> although the standard also allows for returning 'TASK SET FULL' Hannes> or 'BUSY' in these cases. Doing so would nicely solve this Hannes> issue. I agree with Hannes that it would be appropriate for the SATL to report busy when it makes an non-queued command queueable. -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v2) Date: Fri, 04 Nov 2016 12:35:00 -0400 Message-ID: References: <2179ecb8-183f-a500-4d65-10f64f0f43cc@suse.de> <1478045394-19536-1-git-send-email-andrey2805@gmail.com> <30w645ulbhlofxrk1h4a9q3s.1478144944778@email.android.com> <38e3e634-6e08-58bd-bc11-8a0a470b78d9@suse.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <38e3e634-6e08-58bd-bc11-8a0a470b78d9@suse.de> (Hannes Reinecke's message of "Fri, 4 Nov 2016 15:51:45 +0100") Sender: stable-owner@vger.kernel.org To: Hannes Reinecke Cc: Sreekanth Reddy , Igor Rybak , Andrey Grodzovsky , Ezra Kohavi , PDL-MPT-FUSIONLINUX , "linux-scsi@vger.kernel.org" , Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , "stable@vger.kernel.org" List-Id: linux-scsi@vger.kernel.org >>>>> "Hannes" == Hannes Reinecke writes: Hannes> Checking with SAT-3 (section 6.2.4: Commands the SATL queues Hannes> internally) the implemented behaviour is standards conformant, Hannes> although the standard also allows for returning 'TASK SET FULL' Hannes> or 'BUSY' in these cases. Doing so would nicely solve this Hannes> issue. I agree with Hannes that it would be appropriate for the SATL to report busy when it makes an non-queued command queueable. -- Martin K. Petersen Oracle Linux Engineering