From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758149AbcHaCXp (ORCPT ); Tue, 30 Aug 2016 22:23:45 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:29539 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754214AbcHaCXn (ORCPT ); Tue, 30 Aug 2016 22:23:43 -0400 To: Christophe JAILLET Cc: kashyap.desai@avagotech.com, sumit.saxena@avagotech.com, uday.lingala@avagotech.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] megaraid_sas: Fix the search of first memory bar From: "Martin K. Petersen" Organization: Oracle Corporation References: <1471768105-14730-1-git-send-email-christophe.jaillet@wanadoo.fr> Date: Tue, 30 Aug 2016 22:23:34 -0400 In-Reply-To: <1471768105-14730-1-git-send-email-christophe.jaillet@wanadoo.fr> (Christophe JAILLET's message of "Sun, 21 Aug 2016 10:28:25 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Christophe" == Christophe JAILLET writes: Christophe> The 2nd parameter of 'find_first_bit' is the number of bits Christophe> to search. In this case, we are passing 'sizeof(unsigned Christophe> long)' which is likely to be 4. Christophe> It is likely that the number of bits in a long was expected Christophe> here, so use BITS_PER_LONG instead. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Wed, 31 Aug 2016 02:23:34 +0000 Subject: Re: [PATCH] megaraid_sas: Fix the search of first memory bar Message-Id: List-Id: References: <1471768105-14730-1-git-send-email-christophe.jaillet@wanadoo.fr> In-Reply-To: <1471768105-14730-1-git-send-email-christophe.jaillet@wanadoo.fr> (Christophe JAILLET's message of "Sun, 21 Aug 2016 10:28:25 +0200") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: kashyap.desai@avagotech.com, sumit.saxena@avagotech.com, uday.lingala@avagotech.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org >>>>> "Christophe" = Christophe JAILLET writes: Christophe> The 2nd parameter of 'find_first_bit' is the number of bits Christophe> to search. In this case, we are passing 'sizeof(unsigned Christophe> long)' which is likely to be 4. Christophe> It is likely that the number of bits in a long was expected Christophe> here, so use BITS_PER_LONG instead. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering