From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
Douglas Gilbert <dgilbert@interlog.com>,
Khalid Aziz <khalid@gonehiking.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Christoph Hellwig <hch@lst.de>, Nix <nix@esperi.org.uk>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] scsi: Set allocation length to 255 for ATA Information VPD page
Date: Fri, 07 Jan 2022 09:07:59 -0500 [thread overview]
Message-ID: <yq1mtk7wsmb.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <3cb24d6e-d52c-827f-7905-8e17411b23e1@opensource.wdc.com> (Damien Le Moal's message of "Thu, 6 Jan 2022 14:21:24 +0900")
Damien,
> That said, it is weird that scsi_get_vpd_page() does not call
> scsi_device_supports_vpd().
The first patch in the series already makes that change.
I noticed because the allocation for sd_read_cpr() is fairly big so it
stuck out in my test runs while reworking scsi_get_vpd_page().
I didn't remove the conditional in sd_revalidate_disk(). While it is
superfluous, I do like that the "fancy" protocol features are
grouped. Guess we could switch it to a comment instead. I'll think about
it...
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-01-07 14:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-02 23:23 [PATCH v3 0/3] Bring the BusLogic host bus adapter driver up to Y2021 Maciej W. Rozycki
2022-01-02 23:23 ` [PATCH v3 1/3] scsi: Provide for avoiding trailing allocation length with VPD inquiries Maciej W. Rozycki
2022-01-03 8:23 ` Christoph Hellwig
2022-01-04 16:39 ` Khalid Aziz and Shuah Khan
2022-01-04 17:20 ` Maciej W. Rozycki
2022-01-02 23:23 ` [PATCH v3 2/3] scsi: Avoid using reserved length byte " Maciej W. Rozycki
2022-01-02 23:23 ` [PATCH v3 3/3] scsi: Set allocation length to 255 for ATA Information VPD page Maciej W. Rozycki
2022-01-03 4:09 ` Douglas Gilbert
2022-01-03 21:06 ` Maciej W. Rozycki
2022-01-03 21:28 ` Martin K. Petersen
2022-01-04 13:52 ` Maciej W. Rozycki
2022-01-04 17:57 ` Martin K. Petersen
2022-01-06 4:13 ` Martin K. Petersen
2022-01-06 5:21 ` Damien Le Moal
2022-01-07 14:07 ` Martin K. Petersen [this message]
2022-01-07 10:36 ` Maciej W. Rozycki
2022-01-07 14:03 ` Martin K. Petersen
2022-01-10 12:00 ` Maciej W. Rozycki
2022-01-10 15:48 ` Martin K. Petersen
2022-01-03 21:37 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1mtk7wsmb.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dgilbert@interlog.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=khalid@gonehiking.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=nix@esperi.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.