From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755780AbcBWWr3 (ORCPT ); Tue, 23 Feb 2016 17:47:29 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:50618 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755563AbcBWWr2 (ORCPT ); Tue, 23 Feb 2016 17:47:28 -0500 To: "Ewan D. Milne" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, wuninsu@gmail.com, thenzl@redhat.com, sreekanth.reddy@avagotech.com, MPT-FusionLinux.pdl@avagotech.com, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu Subject: Re: [PATCH v3] mptbase: fixup error handling paths in mpt_attach() From: "Martin K. Petersen" Organization: Oracle Corporation References: <1456236012-27300-1-git-send-email-emilne@redhat.com> Date: Tue, 23 Feb 2016 17:47:15 -0500 In-Reply-To: <1456236012-27300-1-git-send-email-emilne@redhat.com> (Ewan D. Milne's message of "Tue, 23 Feb 2016 09:00:12 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Ewan" == Ewan D Milne writes: Ewan> mpt_attach() was not checking for the failure to create Ewan> fw_event_q. Also, iounmap() was not being called in all error Ewan> cases after ioremap() had been called by mpt_mapresources(). Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering