From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Lukas Herbolt <lherbolt@redhat.com>
Cc: dgilbert@interlog.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_debug: Add OPTIMAL TRANSFER LENGTH GRANULARITY option.
Date: Fri, 20 Jan 2017 19:24:24 -0500 [thread overview]
Message-ID: <yq1pojhgszr.fsf@oracle.com> (raw)
In-Reply-To: <1483779027-10052-1-git-send-email-lherbolt@redhat.com> (Lukas Herbolt's message of "Sat, 7 Jan 2017 09:50:26 +0100")
>>>>> "Lukas" == Lukas Herbolt <lherbolt@redhat.com> writes:
Lukas,
Lukas> I have been playing with scsi_debug and found that there is no
Lukas> way how to change the minimum_io_size (OPTIMAL TRANSFER LENGTH
Lukas> GRANULARITY reported by VPD 0xb0).
Lukas> The current module has minimum_io_size always set to
Lukas> physical_block_size. So here comes a small patch which add a new
Lukas> option to this module to be able to set it independently to the
Lukas> physical_block_size. Default behavior is to keep the
Lukas> minimum_io_size equal to the physical_block_size.
No objection to the functionality but I don't really like the naming
scheme. There are many granularities in SBC so "gran" isn't particularly
descriptive.
How about opt_xferlen_exp or something like that?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-01-21 0:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 8:50 [PATCH] scsi_debug: Add OPTIMAL TRANSFER LENGTH GRANULARITY option Lukas Herbolt
2017-01-07 8:50 ` Lukas Herbolt
2017-01-21 0:24 ` Martin K. Petersen [this message]
2017-01-24 11:41 ` Lukas Herbolt
2017-01-25 23:31 ` Martin K. Petersen
2017-01-26 9:00 Lukas Herbolt
2017-02-01 3:09 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1pojhgszr.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dgilbert@interlog.com \
--cc=lherbolt@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.