From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751349AbdHaCDY (ORCPT ); Wed, 30 Aug 2017 22:03:24 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42176 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbdHaCDX (ORCPT ); Wed, 30 Aug 2017 22:03:23 -0400 To: Nikola Pajkovsky Cc: Adaptec OEM Raid Solutions , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from aac_convert_sgraw2() From: "Martin K. Petersen" Organization: Oracle Corporation References: <29ed79bb97060429247eeafc9d6d8f6793a7f6b5.1504007944.git.npajkovsky@suse.cz> Date: Wed, 30 Aug 2017 22:03:10 -0400 In-Reply-To: <29ed79bb97060429247eeafc9d6d8f6793a7f6b5.1504007944.git.npajkovsky@suse.cz> (Nikola Pajkovsky's message of "Tue, 29 Aug 2017 13:59:04 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nikola, > aac_convert_sgraw2() kmalloc memory and return -1 on error, which > should be -ENOMEM. However, nobody is checking return value, so with > this change, -ENOMEM is propagated to upper layer. Applied to 4.14/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering