From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933030AbbLOBzr (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Dec 2015 20:55:47 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:36797 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932695AbbLOBzq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Dec 2015 20:55:46 -0500
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>, emilne@redhat.com,
        Lee Duncan <lduncan@suse.com>,
        James Bottomley <James.Bottomley@HansenPartnership.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Tejun Heo <tj@kernel.org>, Hannes Reinecke <hare@suse.com>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <cover.1444241058.git.lduncan@suse.com>
	<f89fe3933ae899dc01f2eddd2a0cefac3383cf3c.1444241058.git.lduncan@suse.com>
	<1444830904.2220.28.camel@HansenPartnership.com>
	<561EA018.7020700@suse.com>
	<1444848835.2220.50.camel@HansenPartnership.com>
	<5644BEE1.3010208@suse.com> <yq1ziyhy38c.fsf@sermon.lab.mkp.net>
	<5649C79E.9070603@suse.de> <564A4EDC.8060805@suse.com>
	<yq1d1v8tdr3.fsf@sermon.lab.mkp.net> <5669F31C.2010409@suse.com>
	<1449847911.4067.200.camel@localhost.localdomain>
	<566DC3F0.6050206@suse.com>
	<1450105632.4091.17.camel@localhost.localdomain>
	<566EE055.9050708@suse.de>
Date: Mon, 14 Dec 2015 20:55:04 -0500
In-Reply-To: <566EE055.9050708@suse.de> (Hannes Reinecke's message of "Mon, 14
	Dec 2015 16:29:25 +0100")
Message-ID: <yq1r3iowk5j.fsf@sermon.lab.mkp.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>>>> "Hannes" == Hannes Reinecke <hare@suse.de> writes:

>> I'm not opposed to having the module option if others (Martin?) feel
>> they need it, but generally I think it's better to keep things as
>> simple as possible.  So, unless there are strong objections, I would
>> say no.

Hannes> Agreeing with Ewan here.

Hannes> I guess it's up to you to tell us whether you absolutely need a
Hannes> module parameter ...

Still not a big ida fan but since the most people seem to be in favor of
this I guess I'll have to bite the bullet.

I don't see much value in the module parameter since it will require
customers to tweak their configs and reproduce. Not worth the hassle.

-- 
Martin K. Petersen	Oracle Linux Engineering