From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Simon Arlott <simon@octiron.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Pavel Machek <pavel@ucw.cz>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Subject: Re: [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot
Date: Wed, 15 Jul 2020 16:14:23 -0400 [thread overview]
Message-ID: <yq1sgdso7sc.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20200715181145.GA17753@infradead.org> (Christoph Hellwig's message of "Wed, 15 Jul 2020 19:11:45 +0100")
Christoph,
> Except for the fact that I think that usage of the BIT() macro is
> a horrible pattern, this looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Looks good to me too.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-07-15 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 20:56 [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot Simon Arlott
2020-06-29 20:58 ` [PATCH 2/2] x86/reboot/quirks: Add ASRock Z170 Extreme4 Simon Arlott
2020-07-15 18:12 ` Christoph Hellwig
2020-07-15 18:11 ` [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot Christoph Hellwig
2020-07-15 20:14 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1sgdso7sc.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=Damien.LeMoal@wdc.com \
--cc=bp@alien8.de \
--cc=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=hch@infradead.org \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=jejb@linux.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=simon@octiron.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.