From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9D52C32771 for ; Thu, 16 Jan 2020 01:59:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C97D222C3 for ; Thu, 16 Jan 2020 01:59:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="dV+iWAAv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730412AbgAPB7j (ORCPT ); Wed, 15 Jan 2020 20:59:39 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:52362 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730481AbgAPB7j (ORCPT ); Wed, 15 Jan 2020 20:59:39 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00G1vwbl045643; Thu, 16 Jan 2020 01:59:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=Mu/Po2KfYHCzcy5f5kf08m8Cx0nl0lBtZm307EHeUTg=; b=dV+iWAAvtfxfAKuCHB56Jm3x5TtvpHXCmbelAtlvks2Qflpdv89JuCE3Omrb53mKKOw3 d/nZcmKY4LHRCjHzFSWturZhLuPsTVKtbLwXZEUIOBDhXYTREbEZo5LJxLWR+SudHawa eqzoQYJtbAbrgzAfHOyLx7E+KeYxdq/bxA/EJGJq7M+0M5ON2mANIs0zeC/gpWV7+sk7 pflrxiRDhQGzox9roBD0Qq8AOJENVWv+iaOnwfRdM+YP+MIh/U7yBxUsmaG7EQ8RdF8T bPtuO85TPskecgUB/rnPu3diApmN7RLWyrh+n8m4Fzb1L/j5IZzdcWlggP6xo/s78Dji sA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2xf73yqr3p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Jan 2020 01:59:34 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00G1rohe153343; Thu, 16 Jan 2020 01:59:34 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2xhy22e618-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Jan 2020 01:59:34 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 00G1xWLO032402; Thu, 16 Jan 2020 01:59:33 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 15 Jan 2020 17:59:31 -0800 To: Mikulas Patocka Cc: Jens Axboe , dm-devel@redhat.com, linux-block@vger.kernel.org, Mike Snitzer Subject: Re: [PATCH] block: fix an integer overflow in logical block size From: "Martin K. Petersen" Organization: Oracle Corporation References: Date: Wed, 15 Jan 2020 20:59:29 -0500 In-Reply-To: (Mikulas Patocka's message of "Wed, 15 Jan 2020 08:35:25 -0500 (EST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9501 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=742 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001160014 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9501 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=817 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001160014 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Mikulas, > This patch changes the logical block size from unsigned short to > unsigned int to avoid the overflow. Looks fine. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering