From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH resend 2/2] mpt3sas: Remove unnecessary synchronize_irq() before free_irq() Date: Tue, 08 Mar 2016 20:52:57 -0500 Message-ID: References: <1457086507-5937-1-git-send-email-lars@metafoo.de> <1457086507-5937-2-git-send-email-lars@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:20848 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbcCIBxT (ORCPT ); Tue, 8 Mar 2016 20:53:19 -0500 In-Reply-To: <1457086507-5937-2-git-send-email-lars@metafoo.de> (Lars-Peter Clausen's message of "Fri, 4 Mar 2016 11:15:07 +0100") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Lars-Peter Clausen Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , Jitendra Bhivare , linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com >>>>> "Lars-Peter" == Lars-Peter Clausen writes: Lars-Peter> Calling synchronize_irq() right before free_irq() is quite Lars-Peter> useless. On one hand the IRQ can easily fire again before Lars-Peter> free_irq() is entered, on the other hand free_irq() itself Lars-Peter> calls synchronize_irq() internally (in a race condition free Lars-Peter> way), before any state associated with the IRQ is freed. Broadcom folks, please review. -- Martin K. Petersen Oracle Linux Engineering