From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752842AbaGVD5f (ORCPT ); Mon, 21 Jul 2014 23:57:35 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:25702 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147AbaGVD5d (ORCPT ); Mon, 21 Jul 2014 23:57:33 -0400 To: Christoph Hellwig Cc: James Bottomley , linux-scsi@vger.kernel.org, Jens Axboe , Bart Van Assche , Mike Christie , "Martin K. Petersen" , Robert Elliott , Webb Scales , linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/14] scsi: convert target_busy to an atomic_t From: "Martin K. Petersen" Organization: Oracle Corporation References: <1405678393-11497-1-git-send-email-hch@lst.de> <1405678393-11497-7-git-send-email-hch@lst.de> Date: Mon, 21 Jul 2014 23:56:56 -0400 In-Reply-To: <1405678393-11497-7-git-send-email-hch@lst.de> (Christoph Hellwig's message of "Fri, 18 Jul 2014 12:13:05 +0200") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Christoph" == Christoph Hellwig writes: Christoph> Avoid taking the host-wide host_lock to check the per-target Christoph> queue limit. Instead we do an atomic_inc_return early on to Christoph> grab our slot in the queue, and if nessecary decrement it Minor nit: necessary Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering