From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, raphasil@linux.vnet.ibm.com,
james.smart@broadcom.com, dick.kennedy@broadcom.com,
jsmart2021@gmail.com
Subject: Re: [PATCH] scsi: lpfc: Avoid NULL pointer dereference in lpfc_els_abort()
Date: Wed, 31 May 2017 22:47:00 -0400 [thread overview]
Message-ID: <yq1vaogl90b.fsf@oracle.com> (raw)
In-Reply-To: <20170524214851.25428-1-gpiccoli@linux.vnet.ibm.com> (Guilherme G. Piccoli's message of "Wed, 24 May 2017 18:48:51 -0300")
Guilherme,
> We might have a NULL pring in lpfc_els_abort(), for example on error
> recovery path, since queues are destroyed during error recovery
> mechanism.
>
> In this case, we should just drop the abort since the queues will be
> recreated anyway. This patch just verifies for NULL pointer and stop
> the abortion of the queue in case of a NULL pring.
>
> Also, this patch converts return type of lpfc_els_abort() from int to
> void, since it's not checked anywhere.
Applied to 4.12/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-06-01 2:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 21:48 [PATCH] scsi: lpfc: Avoid NULL pointer dereference in lpfc_els_abort() Guilherme G. Piccoli
2017-05-29 8:19 ` Johannes Thumshirn
2017-05-29 23:07 ` James Smart
2017-06-01 2:47 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1vaogl90b.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dick.kennedy@broadcom.com \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=james.smart@broadcom.com \
--cc=jsmart2021@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=raphasil@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.