From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752764AbdJKSdy (ORCPT ); Wed, 11 Oct 2017 14:33:54 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:40297 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752045AbdJKSdx (ORCPT ); Wed, 11 Oct 2017 14:33:53 -0400 To: Johannes Thumshirn Cc: "Martin K . Petersen" , Linux Kernel Mailinglist , Linux SCSI Mailinglist Subject: Re: [PATCH v3] scsi: fc: check for rport presence in fc_block_scsi_eh From: "Martin K. Petersen" Organization: Oracle Corporation References: <20171010153138.21542-1-jthumshirn@suse.de> Date: Wed, 11 Oct 2017 14:33:46 -0400 In-Reply-To: <20171010153138.21542-1-jthumshirn@suse.de> (Johannes Thumshirn's message of "Tue, 10 Oct 2017 17:31:38 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johannes, > Coverity-scan recently found a possible NULL pointer dereference in > fc_block_scsi_eh() as starget_to_rport() either returns the rport for > the startget or NULL. > > While it is rather unlikely to have fc_block_scsi_eh() called without > an rport associated it's a good idea to catch potential misuses of the > API gracefully. Applied to 4.14/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering