From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jan Kara <jack@suse.cz>
Cc: Jim Gill <jgill@vmware.com>,
VMware PV-Drivers <pv-drivers@vmware.com>,
linux-scsi@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] scsi: vmw_pscsi: Fix use-after-free in pvscsi_queue_lck()
Date: Thu, 20 Jun 2019 16:35:05 -0400 [thread overview]
Message-ID: <yq1zhmcq9l2.fsf@oracle.com> (raw)
In-Reply-To: <20190619070541.30070-1-jack@suse.cz> (Jan Kara's message of "Wed, 19 Jun 2019 09:05:41 +0200")
Jan,
> Once we unlock adapter->hw_lock in pvscsi_queue_lck() nothing prevents
> just queued scsi_cmnd from completing and freeing the request. Thus
> cmd->cmnd[0] dereference can dereference already freed request leading
> to kernel crashes or other issues (which one of our customers
> observed). Store cmd->cmnd[0] in a local variable before unlocking
> adapter->hw_lock to fix the issue.
Applied to 5.2/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-06-20 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 7:05 [PATCH] scsi: vmw_pscsi: Fix use-after-free in pvscsi_queue_lck() Jan Kara
2019-06-19 15:13 ` Ewan D. Milne
2019-06-20 20:35 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1zhmcq9l2.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=jack@suse.cz \
--cc=jgill@vmware.com \
--cc=linux-scsi@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.