From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Xuewei Zhang <xueweiz@google.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Mikael Pettersson <mikpelinux@gmail.com>
Subject: Re: [PATCH] scsi: sd: fix entropy gathering for most rotational disks
Date: Tue, 12 Feb 2019 11:59:27 -0500 [thread overview]
Message-ID: <yq1zhr1t028.fsf@oracle.com> (raw)
In-Reply-To: <e9a411a2-49e2-4897-4e02-1cf790465cbd@kernel.dk> (Jens Axboe's message of "Tue, 12 Feb 2019 09:06:29 -0700")
Jens,
>> The fix is to set the non-rotational and add-randomness flags
>> unconditionally early on in the disk initialization path, so they can
>> be reset only if the device actually reports being non-rotational via
>> the VPD page.
>
> Reviewed-by: Jens Axboe <axboe@kernel.dk>
Yeah, this looks good to me. I'll queue it up for fixes.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-02-12 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 16:05 [PATCH] scsi: sd: fix entropy gathering for most rotational disks James Bottomley
2019-02-12 16:06 ` Jens Axboe
2019-02-12 16:59 ` Martin K. Petersen [this message]
2019-02-12 20:00 ` Xuewei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1zhr1t028.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mikpelinux@gmail.com \
--cc=xueweiz@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.